<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi,<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 30 Dec 2014, at 21:33, Robert Helling <<a href="mailto:helling@atdotde.de" class="">helling@atdotde.de</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""></div><span id="cid:BD0965D5-5E31-48F8-9621-E8DAE97BE26A@fritz.box"><0001-Only-copy-used-cyliders-to-planned-dive.patch></span><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Dirk, </div><div class=""><br class=""></div><div class="">please double check this patch, as it was you who explicitly wrote there „false“ in <font face="Menlo" class=""><span style="font-size: 11px;" class="">611bae34 for reasons beyond me.</span></font></div><div class=""><font face="Menlo" class=""><span style="font-size: 11px;" class=""><br class=""></span></font></div><div class=""><font face="Menlo" class=""><span style="font-size: 11px;" class="">Best</span></font></div><div class=""><font face="Menlo" class=""><span style="font-size: 11px;" class="">Robert</span></font></div></div></div></blockquote></div><br class=""></div><div class="">since this patch was not accepted and on IRC, Dirk asked for agreement (i.e. discussion): Let me reveal that the concept of „unused tanks“ is a bit beyond me. In which situation would I use them?!? I understand that some dive computers allow their users to preconfigure a number of mixes and those that were not switched to during the dive end up in the cylinder list as unused.</div><div class=""><br class=""></div><div class="">I don’t have such a computer, so to reproduce the bug #798 and test my patch, I had to edit a dive in a text editor (i chose test19.xml) to remove gas change events and thus have unused gases.</div><div class=""><br class=""></div><div class="">I don’t understand why one would want to have unused gases in the first place (except when they come from a dive computer as above) and therefore I do not understand what the expected behaviour for planning starting from a dive with unused gases would be. But I agree with the reporter of #789 that the planner switching to gases that are not in the table of cylinders is certainly not expected behaviour.</div><div class=""><br class=""></div><div class="">That was my reason to make unused gases irrelevant for the planner. But if somebody explains to be a use case for unused gases appearing in the planned dive I would be happy to implement that.</div><div class=""><br class=""></div><div class="">Best</div><div class="">Robert</div></body></html>