<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 21, 2015 at 4:56 AM, Anton Lundin <span dir="ltr"><<a href="mailto:glance@acc.umu.se" target="_blank">glance@acc.umu.se</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 21 January, 2015 - Dirk Hohndel wrote:<br>
<br>
><br>
> So in my state of limited mental capacity due to too much N₂ I've taken<br>
> this series. I bet I'm going to hate myself for this in the near future.<br>
><br>
> Tomaz, can you look through these, please?<br>
><br>
<br>
</span>This code probably leaks some memory, but it ain't that much worse than<br>
the previous code. Just/maybe a QProgressDialog, but i really don't know<br>
how to fix that due to your previous comments about wierd crashes in<br>
4559a26e ("Fix ConfigureDiveComputer class").<br></blockquote><div><br></div><div>I'll look into it. :)<br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
//Anton<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
> On Tue, Jan 20, 2015 at 10:49:56PM +0100, Anton Lundin wrote:<br>
> > Signed-off-by: Anton Lundin <<a href="mailto:glance@acc.umu.se">glance@acc.umu.se</a>><br>
> > ---<br>
> >  qt-ui/configuredivecomputerdialog.cpp | 7 +++++++<br>
> >  1 file changed, 7 insertions(+)<br>
> ><br>
> > diff --git a/qt-ui/configuredivecomputerdialog.cpp b/qt-ui/configuredivecomputerdialog.cpp<br>
> > index 182bf76..2c2814d 100644<br>
> > --- a/qt-ui/configuredivecomputerdialog.cpp<br>
> > +++ b/qt-ui/configuredivecomputerdialog.cpp<br>
> > @@ -6,6 +6,7 @@<br>
> >  #include <QMessageBox><br>
> >  #include <QSettings><br>
> >  #include <QNetworkReply><br>
> > +#include <QProgressDialog><br>
> ><br>
> >  struct product {<br>
> >     const char *product;<br>
> > @@ -281,7 +282,13 @@ void OstcFirmwareCheck::saveOstcFirmware(QNetworkReply *reply)<br>
> >     file.open(QIODevice::WriteOnly);<br>
> >     file.write(firmwareData);<br>
> >     file.close();<br>
> > +   QProgressDialog *dialog = new QProgressDialog("Updating firmware", "", 0, 100);<br>
> > +   dialog->setCancelButton(0);<br>
> > +   dialog->setAutoClose(true);<br>
> >     ConfigureDiveComputer *config = new ConfigureDiveComputer();<br>
> > +   connect(config, SIGNAL(message(QString)), dialog, SLOT(setLabelText(QString)));<br>
> > +   connect(config, SIGNAL(error(QString)), dialog, SLOT(setLabelText(QString)));<br>
> > +   connect(config, SIGNAL(progress(int)), dialog, SLOT(setValue(int)));<br>
> >     config->startFirmwareUpdate(storeFirmware, &devData);<br>
> >  }<br>
> ><br>
> > --<br>
> > 2.1.0<br>
> ><br>
> > _______________________________________________<br>
> > subsurface mailing list<br>
> > <a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a><br>
> > <a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" target="_blank">http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface</a><br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Anton Lundin    <a href="tel:%2B46702-161604" value="+46702161604">+46702-161604</a><br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
subsurface mailing list<br>
<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a><br>
<a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" target="_blank">http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface</a><br>
</div></div></blockquote></div><br></div></div>