<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jan 29, 2015 at 5:47 PM, Robert Helling <span dir="ltr"><<a href="mailto:helling@atdotde.de" target="_blank">helling@atdotde.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Hi,<span class=""><div><br><div><blockquote type="cite"><div>On 29 Jan 2015, at 20:01, Dirk Hohndel <<a href="mailto:dirk@hohndel.org" target="_blank">dirk@hohndel.org</a>> wrote:</div><br><div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">And it doesn't crash on my Mac, either.</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">Can you give more data? Which git version of Subsurface? How did you build</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">it (i.e., which Qt, what tool chain)? Can you reproduce this with the</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">daily binaries from this morning?</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"></div></blockquote></div><br></div></span><div>it does crash for me. The last subsurface code on the stack is line 437 of divelogimportdialog.cpp</div><div><br></div><div>
<pre style="margin-top:0px;margin-bottom:0px"><span style="color:#c0c0c0"> </span>headers.replace(<span style="color:#800000">CSVApps</span>[value].<span style="color:#800000">time</span>,<span style="color:#c0c0c0"> </span>tr(<span style="color:#008000">"Sample</span><span style="color:#c0c0c0"> </span><span style="color:#008000">time"</span>));</pre>
<pre style="margin-top:0px;margin-bottom:0px"><br></pre><div>I have no idea, what this is but I can tell CSCApps is != NULL, value == 3 and there the assertion</div></div><div>
<pre style="margin-top:0px;margin-bottom:0px"><span style="color:#c0c0c0"> </span><span style="color:#000080">Q_ASSERT_X</span>(i<span style="color:#c0c0c0"> </span>>=<span style="color:#c0c0c0"> </span><span style="color:#000080">0</span><span style="color:#c0c0c0"> </span>&&<span style="color:#c0c0c0"> </span>i<span style="color:#c0c0c0"> </span><<span style="color:#c0c0c0"> </span><span style="color:#800000">p</span>.size(),<span style="color:#c0c0c0"> </span><span style="color:#008000">"QList<T>::replace"</span>,<span style="color:#c0c0c0"> </span><span style="color:#008000">"index</span><span style="color:#c0c0c0"> </span><span style="color:#008000">out</span><span style="color:#c0c0c0"> </span><span style="color:#008000">of</span><span style="color:#c0c0c0"> </span><span style="color:#008000">range"</span>);</pre>
<pre style="margin-top:0px;margin-bottom:0px"><br></pre><div>of the replace method fails with „index out of range“ as headers has only one item.</div></div></div></blockquote><div><br></div><div>Most probably the issue is the wrong separator, splitting the data with ',' or ';' may have it caused to have just the first item that contained everything,<br>and trying to acces .time (three) made an invalid index.<br><br></div><div>I *think* we should try to split with another separator if splitString.size == 1<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br></div><div>Let me know what else to look for.</div><div><br></div><div>Best</div><span class="HOEnZb"><font color="#888888"><div>Robert</div></font></span></div><br>_______________________________________________<br>
subsurface mailing list<br>
<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a><br>
<a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" target="_blank">http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface</a><br>
<br></blockquote></div><br></div></div>