<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head><body ><br><br><div>-------- Original message --------</div><div>From: Linus Torvalds <torvalds@linux-foundation.org> </div><div>Date:02/06/2015 08:20 (GMT-08:00) </div><div>To: Dirk Hohndel <dirk@hohndel.org> </div><div>Cc: Subsurface Mailing List <subsurface@subsurface-divelog.org> </div><div>Subject: Re: First patch - Delete dive(s) using the delete key </div><div><br></div>On Fri, Feb 6, 2015 at 7:20 AM, Dirk Hohndel <dirk@hohndel.org> wrote:<br>> Hi Grace,<br>><br>> welcome to the team!<br>><br>> On Fri, Feb 06, 2015 at 02:19:04PM +0300, Grace Karanja wrote:<br>>><br>>> This patch allows the user to delete dives using the delete key.<br>><br>> Excellent.<br><br>Really? This seems like a recipe for mistakes and easy data loss.<br><br>If I read the patch right, there's no confirmation etc, so now just<br>mistakenly pressing the Del key will delete dives. That sounds like a<br>fairly easy way for somebody to fatfinger things and lose data.<br><br>Do we need an undo stack so the user can undo the last few actions?<div><br></div><div>--Steve</div></body>