<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'><div>Sorry. Lost in Translation.</div><div><br></div><div>I caught this bug as follows (pic 1):</div><div>1. Add new dive.</div><div>2. Discard apply changes.</div><div>3. Add another dive.</div><div>4. Pull the last point to the left or down.</div><div>5. Make it a few more times.</div><div><br></div><div>> <span style="font-size: 12pt;">also, not sure i understand what you mean by "second diving graph".</span></div><div>Was trying to say that the problem occurs on the second editing.</div><div><br></div><div>Can I ask you one more time? (pic 2)</div><div>> Given this, should we clean handles every time changes are discarded or<br>> applied?</div><br><span id="ecxresult_box" class="ecxshort_text" lang="en"><span class="ecxhps ecxalt-edited">Regards</span><span>, Matthew</span><span> V.</span></span><br><br><div>> Date: Tue, 17 Mar 2015 12:30:48 +0200<br>> Subject: Re: Patch for #848<br>> From: neolit123@gmail.com<br>> To: matteofichtner@hotmail.com<br>> CC: subsurface@subsurface-divelog.org<br>> <br>> On 17 March 2015 at 01:06, Matthew Vepritskiy<br>> <matteofichtner@hotmail.com> wrote:<br>> > I made a patch for ticket # 848, but I have a suspicion that somewhere I<br>> > screwed up.<br>> > http://trac.subsurface-divelog.org/ticket/848#no2<br>> ><br>> > Patch fixes the problem when you can create a set of points that do not<br>> > belong to the line.<br>> > The problem lies in the function fixHandlerIndex (qt-ui / profile /<br>> > profilewidget2.cpp) - it returns the wrong value.<br>> > However, this only occurs when the user edits the second diving graph. That<br>> > is, before he clicked "Apply Changes" or "Discard changes".<br>> > Given this, should we clean handles every time changes are discarded or<br>> > applied?<br>> ><br>> <br>> i don't think the function should be removed.<br>> this bug was supposedly fixed recently and i can't reproduce it with<br>> the current GIT version. if not, can you provide the exact steps for<br>> the bug to trigger?<br>> also, not sure i understand what you mean by "second diving graph".<br>> <br>> lubomir<br>> --<br></div> </div></body>
</html>