<div dir="ltr"><div>Hi, Iḿ Dileesha from Sri Lanka. Currently I´m an undergraduate majoring in Software Engineering at Informatics Institute of Technology, Sri Lanka (Affiliated with University of Westminster, London). I´m an enthusiastic programmer having an eagerness to gain experience by involving in industrial level projects. I have done some research in Subsurface and decided to involve in it since I think that I have the necessary skills to proceed further with the project.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 23, 2015 at 8:57 PM, <span dir="ltr"><<a href="mailto:subsurface-request@subsurface-divelog.org" target="_blank">subsurface-request@subsurface-divelog.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Send subsurface mailing list submissions to<br>
<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a><br>
<br>
To subscribe or unsubscribe via the World Wide Web, visit<br>
<a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" target="_blank">http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface</a><br>
<br>
or, via email, send a message with subject or body 'help' to<br>
<a href="mailto:subsurface-request@subsurface-divelog.org">subsurface-request@subsurface-divelog.org</a><br>
<br>
You can reach the person managing the list at<br>
<a href="mailto:subsurface-owner@subsurface-divelog.org">subsurface-owner@subsurface-divelog.org</a><br>
<br>
When replying, please edit your Subject line so it is more specific<br>
than "Re: Contents of subsurface digest..."<br>
<br>
<br>
Today's Topics:<br>
<br>
1. Re: Coding Style - C++ constructor initialization list<br>
(Dirk Hohndel)<br>
2. Re: Coding Style - C++ constructor initialization list<br>
(Dirk Hohndel)<br>
3. Re: [PATCH] CodingStyle: add an extra line for the braces<br>
explaination (Lubomir I. Ivanov)<br>
4. Re: Customizable Print Formats GSoC 2015 (Lubomir I. Ivanov)<br>
5. Re: [PATCH] Fix some memory leaks (Lubomir I. Ivanov)<br>
6. Re: [PATCH] fixed #404 Corrects volumes of cylinders<br>
(Anton Lundin)<br>
7. Re: [PATCH] Fix some memory leaks (Lubomir I. Ivanov)<br>
8. Re: [PATCH] initializing members (Lubomir I. Ivanov)<br>
<br>
<br>
----------------------------------------------------------------------<br>
<br>
Message: 1<br>
Date: Mon, 23 Mar 2015 05:51:26 -0700<br>
From: Dirk Hohndel <<a href="mailto:dirk@hohndel.org">dirk@hohndel.org</a>><br>
To: Marcos Cardinot <<a href="mailto:mcardinot@gmail.com">mcardinot@gmail.com</a>><br>
Cc: Subsurface Mailing List <<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a>><br>
Subject: Re: Coding Style - C++ constructor initialization list<br>
Message-ID: <<a href="mailto:20150323125126.GH1256@rrmbp.gr8dns.org">20150323125126.GH1256@rrmbp.gr8dns.org</a>><br>
Content-Type: text/plain; charset=utf-8<br>
<br>
On Mon, Mar 23, 2015 at 12:59:39AM -0300, Marcos Cardinot wrote:<br>
> Hello folks,<br>
><br>
> It is just a naive discussion about coding style... =D<br>
<br>
Our favorite topic :-)<br>
<br>
> According to the CodingStyle.txt:<br>
><br>
> *"- in a C++ constructor initialization list, the colon is on the same line<br>
> and*<br>
> * continuation lines are aligned as the rule above:*<br>
><br>
> * ClassName::ClassName() : x(1), y(2),*<br>
> * z(3)*<br>
> * {*<br>
> * }"*<br>
<br>
Whitespace did you in here.<br>
<br>
Yes, it turns out that this is not quite what the we ended up with.<br>
<br>
> As you know, most of the classes does not follow this rule yet, but it's<br>
> fine, since it looks like a new rule =D<br>
><br>
> However, in this format, the next lines would usually require some white<br>
> spaces (in order to do a correct alignment), but it might not be a good<br>
> idea, because the alignment would depends on the editor...<br>
<br>
Well, no. Tab is 8 spaces so this is not editor specific<br>
<br>
> In addition, writing many (more than one) members at the same line is less<br>
> readable than writing only one...<br>
><br>
> My suggestion is that for this case, we should have a style in which we<br>
> would never need to use white spaces...<br>
> for example:<br>
> *ClassName::ClassName() :*<br>
> *x(1),*<br>
> *y(2),*<br>
> *z(3)*<br>
> *{*<br>
> *}*<br>
<br>
This isn't readable for me. Possibly a mail formating issue.<br>
What we really have and should have is<br>
<br>
ClassName::memberFunction() : x(1),<br>
y(2),<br>
z(3)<br>
{<br>
}<br>
<br>
So y and z are indented by exactly one tab.<br>
<br>
> *ClassName::ClassName()*<br>
> * : **x(1),*<br>
<br>
NO. I absolutely hate having the "connecting" character at the start of<br>
the next line.<br>
<br>
/D<br>
<br>
<br>
------------------------------<br>
<br>
Message: 2<br>
Date: Mon, 23 Mar 2015 05:52:57 -0700<br>
From: Dirk Hohndel <<a href="mailto:dirk@hohndel.org">dirk@hohndel.org</a>><br>
To: Boris Barbulovski <<a href="mailto:bbarbulovski@gmail.com">bbarbulovski@gmail.com</a>><br>
Cc: Subsurface Mailing List <<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a>><br>
Subject: Re: Coding Style - C++ constructor initialization list<br>
Message-ID: <<a href="mailto:20150323125257.GI1256@rrmbp.gr8dns.org">20150323125257.GI1256@rrmbp.gr8dns.org</a>><br>
Content-Type: text/plain; charset=utf-8<br>
<br>
On Mon, Mar 23, 2015 at 09:44:33AM +0100, Boris Barbulovski wrote:<br>
> or maybe like this:<br>
><br>
> *ClassName::ClassName()*<br>
> * : **x(1)*<br>
> * , **y(2)*<br>
> * , **z(3)*<br>
> *{*<br>
> *}*<br>
><br>
> Benefits:<br>
> * Members are aligned(easy to read)<br>
> * Eazyer for adding new members to the end of the list(no need to worry<br>
> about the comma to last entry)<br>
<br>
Downsides: UGLY and hard on my eyes.<br>
<br>
I know quite a few projects do this, I just don't like this. Sorry<br>
<br>
/D<br>
<br>
<br>
------------------------------<br>
<br>
Message: 3<br>
Date: Mon, 23 Mar 2015 16:03:28 +0200<br>
From: "Lubomir I. Ivanov" <<a href="mailto:neolit123@gmail.com">neolit123@gmail.com</a>><br>
To: Subsurface Mailing List <<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a>><br>
Subject: Re: [PATCH] CodingStyle: add an extra line for the braces<br>
explaination<br>
Message-ID:<br>
<CAGDbWi8Kry4Og6CGwTWnHgGioec=pF=<a href="mailto:B3jrYrFhM_2QyPEQonw@mail.gmail.com">B3jrYrFhM_2QyPEQonw@mail.gmail.com</a>><br>
Content-Type: text/plain; charset=UTF-8<br>
<br>
> 18 March 2015 at 02:22, Lubomir I. Ivanov <<a href="mailto:neolit123@gmail.com">neolit123@gmail.com</a>> wrote:<br>
> From: "Lubomir I. Ivanov" <<a href="mailto:neolit123@gmail.com">neolit123@gmail.com</a>><br>
><br>
> The extra call "dosomethingelse()" is added with the<br>
> intention that user will not be confused to add braces<br>
> around single lined "if" conditions.<br>
><br>
> Signed-off-by: Lubomir I. Ivanov <<a href="mailto:neolit123@gmail.com">neolit123@gmail.com</a>><br>
> ---<br>
> CodingStyle | 1 +<br>
> 1 file changed, 1 insertion(+)<br>
><br>
> diff --git a/CodingStyle b/CodingStyle<br>
> index 75aa1d4..ead24d0 100644<br>
> --- a/CodingStyle<br>
> +++ b/CodingStyle<br>
> @@ -42,6 +42,7 @@ Basic rules<br>
><br>
> if (condition) {<br>
> dosomething();<br>
> + dosomethingelse();<br>
> }<br>
><br>
> - both sides of an if / else clause either use or do not use curly braces:<br>
<br>
bump.<br>
<br>
lubomir<br>
--<br>
<br>
<br>
------------------------------<br>
<br>
Message: 4<br>
Date: Mon, 23 Mar 2015 16:10:01 +0200<br>
From: "Lubomir I. Ivanov" <<a href="mailto:neolit123@gmail.com">neolit123@gmail.com</a>><br>
To: Gehad Elrobey <<a href="mailto:gehadelrobey@gmail.com">gehadelrobey@gmail.com</a>><br>
Cc: Subsurface Mailing List <<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a>><br>
Subject: Re: Customizable Print Formats GSoC 2015<br>
Message-ID:<br>
<CAGDbWi_sE4adU3dZuYPB3k=S1zNgbB+=<a href="mailto:oL%2BP0btviOPKSAxhpg@mail.gmail.com">oL+P0btviOPKSAxhpg@mail.gmail.com</a>><br>
Content-Type: text/plain; charset=UTF-8<br>
<br>
On 22 March 2015 at 22:57, Gehad Elrobey <<a href="mailto:gehadelrobey@gmail.com">gehadelrobey@gmail.com</a>> wrote:<br>
> Hello,<br>
><br>
> I have attached an updated version of my proposal.<br>
> I am glad to hear any remarks.<br>
><br>
<br>
thanks for the update, Gehad.<br>
i have no more remarks ATM.<br>
<br>
if others are interested in the future printing capabilities of<br>
Subsurface, you can have a look.<br>
<br>
lubomir<br>
--<br>
<br>
<br>
------------------------------<br>
<br>
Message: 5<br>
Date: Mon, 23 Mar 2015 16:55:09 +0200<br>
From: "Lubomir I. Ivanov" <<a href="mailto:neolit123@gmail.com">neolit123@gmail.com</a>><br>
To: Claudiu Olteanu <<a href="mailto:olteanu.vasilica.claudiu@gmail.com">olteanu.vasilica.claudiu@gmail.com</a>>, Salvador<br>
Cuñat <<a href="mailto:salvador.cunat@gmail.com">salvador.cunat@gmail.com</a>><br>
Cc: Subsurface Mailing List <<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a>><br>
Subject: Re: [PATCH] Fix some memory leaks<br>
Message-ID:<br>
<CAGDbWi9CHwVNoPjEVcK8LC62ZYWCg1+xGC=<a href="mailto:H1vL6H8pRRvgsgw@mail.gmail.com">H1vL6H8pRRvgsgw@mail.gmail.com</a>><br>
Content-Type: text/plain; charset=UTF-8<br>
<br>
On 22 March 2015 at 13:48, Claudiu Olteanu<br>
<<a href="mailto:olteanu.vasilica.claudiu@gmail.com">olteanu.vasilica.claudiu@gmail.com</a>> wrote:<br>
> Hello,<br>
><br>
> This patch fixes some memory leaks from datatrak implementation.<br>
><br>
<br>
it could clash with a change that the author / maintainer (Salvador)<br>
has recently sent.<br>
(the patch is not in master yet)<br>
[PATCH] [datatrak.c] Improve error management<br>
<br>
but the free() calls in your patch look appropriately placed.<br>
<br>
this:<br>
- free (fileheader);<br>
+ free(fileheader);<br>
<br>
is a whitespace fix. still in the context of the memory leaks, but<br>
Dirk may not like it.<br>
<br>
lubomir<br>
--<br>
<br>
<br>
------------------------------<br>
<br>
Message: 6<br>
Date: Mon, 23 Mar 2015 16:08:30 +0100<br>
From: Anton Lundin <<a href="mailto:glance@acc.umu.se">glance@acc.umu.se</a>><br>
To: Harshal Jalan <<a href="mailto:harshal.jalan@gmail.com">harshal.jalan@gmail.com</a>><br>
Cc: <a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a><br>
Subject: Re: [PATCH] fixed #404 Corrects volumes of cylinders<br>
Message-ID: <<a href="mailto:20150323150830.GB26336@kennedy.acc.umu.se">20150323150830.GB26336@kennedy.acc.umu.se</a>><br>
Content-Type: text/plain; charset=utf-8<br>
<br>
On 22 March, 2015 - Harshal Jalan wrote:<br>
<br>
> The volumes of cylinders displayed in equipments tab was wrong. It was<br>
> corrected by changing data about the cylinders in the code.<br>
> Please have a look at the attached patch and suggest changes...<br>
><br>
> Harshal Jalan<br>
<br>
> From f6adc09d5aa9d8a5a9f958c318e14d2dc62dd781 Mon Sep 17 00:00:00 2001<br>
> From: Harshal Jalan <<a href="mailto:harshal.jalan@gmail.com">harshal.jalan@gmail.com</a>><br>
> Date: Sun, 22 Mar 2015 22:30:07 +0530<br>
> Subject: [PATCH] [PATCH] Fixed #404 Corrects volumes of cylinders<br>
> The volumes of cylinders displayed in equipments tab was wrong.<br>
> It was corrected by changing data about the cylinders in the code.<br>
><br>
> Signed-off-by: Harshal Jalan <<a href="mailto:harshal.jalan@gmail.com">harshal.jalan@gmail.com</a>><br>
> ---<br>
> equipment.c | 30 +++++++++++++++---------------<br>
> 1 file changed, 15 insertions(+), 15 deletions(-)<br>
><br>
> diff --git a/equipment.c b/equipment.c<br>
> index aebac51..dfde924 100644<br>
> --- a/equipment.c<br>
> +++ b/equipment.c<br>
> @@ -141,28 +141,28 @@ struct tank_info_t tank_info[100] = {<br>
> { "11.1ℓ", .ml = 11100 },<br>
><br>
> /* Most common AL cylinders */<br>
> - { "AL40", .cuft = 40, .psi = 3000 },<br>
> - { "AL50", .cuft = 50, .psi = 3000 },<br>
> - { "AL63", .cuft = 63, .psi = 3000 },<br>
> - { "AL72", .cuft = 72, .psi = 3000 },<br>
> - { "AL80", .cuft = 80, .psi = 3000 },<br>
> - { "AL100", .cuft = 100, .psi = 3300 },<br>
> + { "AL40", .ml = 5700, .bar = 207 },<br>
> + { "AL50", .ml = 6900, .bar = 207 },<br>
> + { "AL63", .ml = 9000, .bar = 207 },<br>
> + { "AL72", .ml = 6900, .bar = 207 },<br>
> + { "AL80", .ml = 11100, .bar = 207 },<br>
> + { "AL100", .ml = 13200, .bar = 228 },<br>
<br>
There's four spaces as indentation here. It should be one tab.<br>
<br>
//Anton<br>
<br>
--<br>
Anton Lundin +46702-161604<br>
<br>
<br>
------------------------------<br>
<br>
Message: 7<br>
Date: Mon, 23 Mar 2015 17:20:34 +0200<br>
From: "Lubomir I. Ivanov" <<a href="mailto:neolit123@gmail.com">neolit123@gmail.com</a>><br>
To: Claudiu Olteanu <<a href="mailto:olteanu.vasilica.claudiu@gmail.com">olteanu.vasilica.claudiu@gmail.com</a>><br>
Cc: Subsurface Mailing List <<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a>><br>
Subject: Re: [PATCH] Fix some memory leaks<br>
Message-ID:<br>
<CAGDbWi-5t7+8y9mFbiujYhd+O-o73dkf+Jy=<a href="mailto:yRk2Rrn7UbB3Kw@mail.gmail.com">yRk2Rrn7UbB3Kw@mail.gmail.com</a>><br>
Content-Type: text/plain; charset=UTF-8<br>
<br>
On 22 March 2015 at 17:46, Claudiu Olteanu<br>
<<a href="mailto:olteanu.vasilica.claudiu@gmail.com">olteanu.vasilica.claudiu@gmail.com</a>> wrote:<br>
> I added more patches which will fix some memory leaks.<br>
> Regarding the uemis-downloader.c source I am not sure if<br>
> "iparam_buff" and "mbuf" variables should be freed too.<br>
><br>
> I saw that one of the elements of "param_buff" is used as a result for the<br>
> "do_uemis_import" function, but I didn't saw where it is freed.<br>
><br>
<br>
if you are not sure about a certain memory allocation don't fix it,<br>
because it can create bugs that are very difficult to debug and can<br>
only be tested fully on a specific device. :\<br>
i don't have the time to check "param_buff" ATM, leave it be for now,<br>
or once you find the answer, provide your train of though in the<br>
commit message on why it should be freed.<br>
<br>
1) same as the first message<br>
2) looks good, yet it will go with the process heap map (i.e. one time<br>
leak). still, to silence valgrind or similar tools the change is fine.<br>
3) looks good to me. the string will be strdup-ed, and tmp can be freed.<br>
4) also seems good<br>
<br>
lubomir<br>
--<br>
<br>
<br>
------------------------------<br>
<br>
Message: 8<br>
Date: Mon, 23 Mar 2015 17:31:54 +0200<br>
From: "Lubomir I. Ivanov" <<a href="mailto:neolit123@gmail.com">neolit123@gmail.com</a>><br>
To: Marcos Cardinot <<a href="mailto:mcardinot@gmail.com">mcardinot@gmail.com</a>><br>
Cc: Subsurface Mailing List <<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a>><br>
Subject: Re: [PATCH] initializing members<br>
Message-ID:<br>
<<a href="mailto:CAGDbWi-ZhMCfpMgcxLz6pThE10-GCrHTKFfj82f_cJyOwKu6Nw@mail.gmail.com">CAGDbWi-ZhMCfpMgcxLz6pThE10-GCrHTKFfj82f_cJyOwKu6Nw@mail.gmail.com</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
On 23 March 2015 at 06:43, Marcos Cardinot <<a href="mailto:mcardinot@gmail.com">mcardinot@gmail.com</a>> wrote:<br>
<br>
> Hi,<br>
><br>
> The attached patches initialize some members in several classes of the<br>
> qt-ui package...<br>
><br>
><br>
hello,<br>
<br>
do these patches have the idea to solve compiler warnings (what GCC version<br>
and -W level) or potentially dangerous lack of initialization (according to<br>
you)?<br>
if no to both, perhaps we should leave these changes out.<br>
<br>
for instance about 008, the setup() is called in the constructor which will<br>
surely *not* leave the variable uninitialized.<br>
<br>
lubomir<br>
--<br>
-------------- next part --------------<br>
An HTML attachment was scrubbed...<br>
URL: <<a href="http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150323/64415619/attachment.html" target="_blank">http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150323/64415619/attachment.html</a>><br>
<br>
------------------------------<br>
<br>
Subject: Digest Footer<br>
<br>
_______________________________________________<br>
subsurface mailing list<br>
<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a><br>
<a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" target="_blank">http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface</a><br>
<br>
<br>
------------------------------<br>
<br>
End of subsurface Digest, Vol 40, Issue 104<br>
*******************************************<br>
</blockquote></div><br></div>