<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Rick,<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On 18.06.2015, at 16:51, Rick Walsh <<a href="mailto:rickmwalsh@gmail.com" class="">rickmwalsh@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-family: Menlo-Regular; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class="Apple-interchange-newline">The attached patch should do just that. Please have a look.<br class=""></div></div></blockquote><div><br class=""></div><div>Thanks a lot for this. Too bad I currently have virtually no time to look at this in any detail and due to a family wedding this weekend possibly not before Monday.</div><div><br class=""></div><div>Still a few remarks:</div><div><br class=""></div><div>1) Could you split your patch into 2-3 patches, one for the segment type, another one for the new logic? git add -p is very helpful in doing this (as I recently learned).</div><div><br class=""></div><div>2) Don’t use the gamix.gas.permille members directly or you will run into problems since air is stored as 0%O2+0%2He. If you want to treat the special cases separately, you are likely doublicating code. Please always use the helper functions get_o2(&gasmix) and get_he(&gasmix) if you really want the content and to test if two gases are the same, there is gasmix_distance(&gasmix1, &gasmix2).</div><div><br class=""></div><div>3) I must say, I am not really a fan of the 0min stops. But people might convince me. What I had intended to do is to change the plan() such that after doing a gas change, it always waits for a minute (and that minute might later be configurable by the user). I think this is realistic as doing a gas change with all checks while continuously ascending is just unrealistic.</div><div><br class=""></div><div>4) We could have a checkbox to turn on and off the segment type symbols (as we have for duration and runtime). If you want to try that, simply copy the code for those options.</div><div><br class=""></div><div>5) Just a personal preference, i would use <a href="https://en.wikipedia.org/wiki/%E2%86%97" title="↗" class="mw-redirect" style="color: rgb(11, 0, 128); background-image: none; font-family: sans-serif; line-height: 28px; text-align: center; text-decoration: none !important;">↗</a>, <a href="https://en.wikipedia.org/wiki/%E2%86%98" title="↘" class="mw-redirect" style="color: rgb(11, 0, 128); background-image: none; font-family: sans-serif; line-height: 28px; text-align: center; text-decoration: none !important;">↘</a>, <a href="https://en.wikipedia.org/wiki/%E2%86%92_(disambiguation)" title="→ (disambiguation)" class="mw-redirect" style="color: rgb(11, 0, 128); background-image: none; font-family: sans-serif; line-height: 28px; text-align: center; text-decoration: none !important;">→</a> for ascent, descent and stop and not distinguish between stop and constant depth planned segment.</div></div>Best</div><div class="">Robert</div><br class=""><br class=""><div apple-content-edited="true" class="">
<div style="color: rgb(0, 0, 0); font-family: Menlo; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); font-family: Menlo; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); font-family: Menlo; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div style="color: rgb(0, 0, 0); font-family: Menlo; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class="">-- <br class="">.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO<br class="">Robert C. Helling Elite Master Course Theoretical and Mathematical Physics<br class=""> Scientific Coordinator<br class=""> Ludwig Maximilians Universitaet Muenchen, Dept. Physik<br class=""> Phone: +49 89 2180-4523 Theresienstr. 39, rm. B339<br class=""> <a href="http://www.atdotde.de" class="">http://www.atdotde.de</a></div><div style="color: rgb(0, 0, 0); font-family: Menlo; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""></div><div style="color: rgb(0, 0, 0); font-family: Menlo; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Enhance your privacy, use cryptography! My PGP keys have fingerprints</div><div style="color: rgb(0, 0, 0); font-family: Menlo; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">A9D1 A01D 13A5 31FA 6515 BB44 0820 367C 36BC 0C1D and</div><div style="color: rgb(0, 0, 0); font-family: Menlo; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">DCED 37B6 251C 7861 270D 5613 95C7 9D32 9A8D 9B8F</div><div style="color: rgb(0, 0, 0); font-family: Menlo; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""></div></div></div><br class="Apple-interchange-newline"></div><br class="Apple-interchange-newline"><br class="Apple-interchange-newline">
</div>
<br class=""></body></html>