<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 29, 2015, at 4:40 PM, Rick Walsh <<a href="mailto:rickmwalsh@gmail.com" class="">rickmwalsh@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Robert,<br class=""><div class=""><div class="gmail_extra"><br class=""><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><div class="">In general, this all looks good, except for a number of minor points: When doing such a series of patches (and yes, it is good to split them into small functional units) and you later find you want to correct one of the earlier patches, there is git commit —amend and git rebase -i („Rewriting history“) where you can hide the fact, that earlier you committed a typo in a comment and did some miscalculation, see for example </div><div class=""><br class=""></div><div class=""><a href="https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase-i" target="_blank" class="">https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase-i</a></div><div class=""><br class=""></div></div></blockquote><div class="">Thanks, I'm aware of and use --amend, but haven't/hadn't worked out how to use git rebase. Rewriting history sounds useful.<br class=""></div></div></div></div></div></div></blockquote><div><br class=""></div><div>Yes - before sending patch series to me, cleaning them up with git rebase -i is indeed very much appreciated.</div><div>The tutorial that Robert mentioned is not bad.</div><div>Or read this one <a href="http://rypress.com/tutorials/git/rebasing" class="">http://rypress.com/tutorials/git/rebasing</a></div><div><br class=""></div><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><div class="gmail_extra"><div class="gmail_quote"><div class="">I'll send a patch for that.<br class=""></div></div></div></div></div></div></blockquote></div><div class=""><br class=""></div>As a fun little exercise... would you mind redoing the whole series into something beautiful and concise?<div class=""><br class=""></div><div class="">You don't have to - but if you want to learn git rebase then I'll be happy to wait.</div><div class=""><br class=""></div><div class="">/D<br class=""><div class=""><br class=""></div></div></body></html>