<div dir="ltr">Robert,<br><div><div class="gmail_extra"><br><div class="gmail_quote">On 30 August 2015 at 02:32, Robert C. Helling <span dir="ltr"><<a href="mailto:helling@atdotde.de" target="_blank">helling@atdotde.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Rick,<div><br></div><div>you are a hero! Sorting alt these things out.</div><div><div class="h5"><div><br><div><blockquote type="cite"><div>On 29 Aug 2015, at 14:38, Rick Walsh <<a href="mailto:rickmwalsh@gmail.com" target="_blank">rickmwalsh@gmail.com</a>> wrote:</div><br><div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">With this series of patches, we now pass all VPM-B tests</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">[PATCH 01/10] VPM-B Tests: Output first ceiling</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">[PATCH 02/10] Update expected runtime of VPM-B test to match</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">[PATCH 03/10] VPM-B: Use correct gamma values</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">[PATCH 04/10] Use Schreiner water vapour pressure for VPM-B</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">[PATCH 05/10] VPM-B: Calculate crushing pressure on descent</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">[PATCH 06/10] Planner: Change where we clear deco and reset gradients</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">[PATCH 07/10] VPM-B: Remove obsolete first_ceiling_pressure</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">[PATCH 08/10] VPM-B: Round first ceiling pressure up to stop</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">[PATCH 09/10] VPM-B tests: correct typo</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">[PATCH 10/10] VPM-B Tests: Compare against known Subsurface runtime</span></div></blockquote></div><br></div></div></div><div>In general, this all looks good, except for a number of minor points: When doing such a series of patches (and yes, it is good to split them into small functional units) and you later find you want to correct one of the earlier patches, there is git commit —amend and git rebase -i („Rewriting history“)  where you can hide the fact, that earlier you committed a typo in a comment and did some miscalculation, see for example </div><div><br></div><div><a href="https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase-i" target="_blank">https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase-i</a></div><div><br></div></div></blockquote><div>Thanks, I'm aware of and use --amend, but haven't/hadn't worked out how to use git rebase.  Rewriting history sounds useful.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div></div><div>My only worry is 4/10: What is the „Schreiner water vapour pressure“? I already have problems with people giving a name to the solution of the differential equation</div><div><br></div><div>y’(x) = gamma (f(x) - y(x)) </div><div><br></div><div>for f(x) a linear function (some people call this the Schreiner equation when they talk about tissue loadings during an ascent or descent). But how can two different people have different values for water vapour? This is a measurable value (which is temperature dependent of course), see <a href="https://en.wikipedia.org/wiki/Vapour_pressure_of_water" target="_blank">https://en.wikipedia.org/wiki/Vapour_pressure_of_water</a></div></div></blockquote><div><br></div><div>I have explained the Schreiner water vapour pressure in a new patch.  It is an effective value to account for CO2 and a respiratory quotient, Rq.  An alternative could have kept the water vapour pressure the same, but created new constants for CO2 and Rq, and re-written the gas loading equations such that they no longer look familiar.  Let me know if you don't agree with the explanation in my patch.<br><br></div><div>This is separate from the constant depth (Buhmann) vs varying depth (Schreiner) equations.  I agree we do not need to introduce the Schreiner equation as we use a small enough step size.<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br></div><div>I mean, I gave up arguing about the reasonableness of values of VPM-B, they are what they are, but when doing strange things one should no longer pretend that there is a physical basis for something.</div><div><br></div><div>How much difference does this patch (in its corrected version) actually make for run-times?</div></div></blockquote><div><br></div><div> The difference appears to be ~2% of decompression time.<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br></div><div>Also, don’t test prefs.deco_mode alone, always use it in conjunction with in_planner() (maybe we need a macro or inline function for that) since, at least so far, the deco mode only has a relevance in the planner and when plotting profiles outside the planner, we always use Buehlmann.</div><div><br></div></div></blockquote><div>I'll send a patch for that.<br><br></div><div>Cheers,<br><br></div><div>Rick<br></div></div></div></div></div>