<HTML><BODY><div id="composeWebView_editable_content" data-mailruapp-compose-id="composeWebView_editable_content" style="text-align: left;">Hi Dirk<div><br></div><div>That was actually the next thing I am working on after I have fixed a nasty bug that I found after merging two dives together.</div><div>Is is Uemis code specific.</div><div><br></div><div>I realize the code doesn't read nice but wanted something working before looking at cosmetics.</div><div>Retrospectively this was a bad idea as I don't think of that others are going to review.</div><div><br></div><div>Thanks for the bday wishes I am back on the code Monday and try to finish all next week.</div><div><br></div><div>I have now loaded over 1000 dives successfully using 2 different Uemis and hope the code does the job for others do after I fixed the bug I found this morning.<br><div><br>G. Lerch<br><br><br>Freitag, 11. September 2015 18:28 +0200 von Dirk Hohndel <dirk@hohndel.org>:<br> <div id="composeWebView_previouse_content" data-mailruapp-compose-id="composeWebView_previouse_content"><blockquote style="border-left: 1px solid #fc2c38; margin: 10px 10px 10px 5px; padding: 0 0 0 10px;"><div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<base target="_self" href="https://e-aj.my.com/">
<div id="style_14419889090000003354_BODY">On Fri, Sep 11, 2015 at 09:12:18AM +0200, Guido Lerch wrote:<br>
<div class="mail-quote-collapse">> some code optimisation and cleanup<br>
</div><br>
Thanks, Guido. #10 you had already sent and I pushed it to master<br>
yesterday. I took #11 and 12 and will push them after some more testing<br>
here.<br>
<br>
One thought. now that you understand the code better, maybe you can<br>
restructure it to be more readable? The level of indentation is a<br>
screaming testament to the fact that this needs more helper functions. By<br>
breaking out parts of the code into functions with good names (even if<br>
they are used just once) will make the code more readable and more easily<br>
debuggable.<br>
<br>
This is again something that could be done one block at a time. So grab<br>
something that's way deeply indented. Think of a good name. Create a<br>
static function and call it from the original spot (making sure the<br>
functionality is otherwise identical). That's one commit.<br>
Now do it again for the next block.<br>
<br>
And feel free to remove pointless debug output while you do that.<br>
<br>
Makes sense?<br>
<br>
Oh, and Herzlichen Glückwunsch zum Geburtstag!<br>
<br>
/D<br>
<br>
</div>
<base target="_self" href="https://e-aj.my.com/">
</div>
</div></blockquote></div></div></div></div></BODY></HTML>