<HTML><BODY><div id="composeWebView_editable_content" data-mailruapp-compose-id="composeWebView_editable_content" style="text-align: left;">Hi Dirk<div><br></div><div>I am fine, of course, with Linus' patch.</div><div>I dispute however that I was ever against the threshold unless I misunderstand something here. I also did no changes to any code concerning threshold. My work was focussed on getting the raw data in trying to deal with all uemis oddities.</div><div><br></div><div>You and I never discussed a threshold, that must have been someone else.</div><div><br></div><div>Nevertheless I'll try to get the last master with my lousy internet connection here in Egypt and continue testing.</div><div><br></div><div>I still suffer from not knowing the code too well and need to still learn a lot.</div><div>For example while trying to implement the pressure drop approach I found that even changing the base64 string wouldn't to anything to the equipment data nor the sac calculations. I spend 2 hours and didn't find out why because I am still so new to anything that is outside the uemis loader that I start to wonder whether I am useful at all.<br><div><br>G. Lerch<br><br><br>Montag, 28. September 2015 13:58 +0200 von Dirk Hohndel <dirk@hohndel.org>:<br> <div id="composeWebView_previouse_content" data-mailruapp-compose-id="composeWebView_previouse_content"><blockquote style="border-left: 1px solid #fc2c38; margin: 10px 10px 10px 5px; padding: 0 0 0 10px;"><div class="js-helper js-readmsg-msg">
<style type="text/css"></style>
<div>
<base target="_self" href="https://e-aj.my.com/">
<div id="style_14434415210000003761_BODY">On Mon, Sep 28, 2015 at 01:56:24PM +0300, Guido Lerch wrote:<br>
> <br>
> Hi Linus,<br>
> <br>
> I just realized the same, none of my code changes do anything to the<br>
> events<br>
<br>
This has nothing to do with events. Remember how we talked about the fact<br>
that you didn't like it that my original code dropped all the samples that<br>
had a depth smaller than SURFACE_THRESHOLD? The fact that we no longer<br>
doing that is what causes the effect that Linus observed.<br>
<br>
> but I am working on a patch to detect pressure drops that happen<br>
> if you decouple the regulator before the uemis has finished its dive<br>
> which is usually 2-3 minutes after you surface.<br>
<br>
I think that Linus existing solution has some merit independently of what<br>
you are proposing. Yes, detecting such pressure drops helps with an oddity<br>
that the Uemis creates because it keeps storing samples for such a long<br>
time after the end of the dive and that possibly other dive computers<br>
might cause as well.<br>
<br>
But Linus' patch fundamentally changes the way we consider SAC - it only<br>
starts the calculation at the first sample where the diver is under water<br>
and ends at the last sample where the diver is under water. On a computer<br>
with a slow sample rate this might introduce a small inaccuracy (as you<br>
might be missing as much as the first and last minute of your dive), but<br>
for most current dive computers that tend to sample at 30s or faster it's<br>
just a hand full of breaths and the overall result is likely more accurate<br>
as it also misses the initial cooling of the tank.<br>
<br>
> If you have done some fixes already please let me know so we do not<br>
> duplicate efforts. If you haven't it's a good learning for me but will<br>
> take some time as I don't know that part of the code yet.<br>
<br>
Linus' patch is in master - I pushed it earlier.<br>
<br>
/D<br>
</div>
<base target="_self" href="https://e-aj.my.com/">
</div>
</div></blockquote></div></div></div></div></BODY></HTML>