<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 26 October 2015 at 18:42, Dirk Hohndel <span dir="ltr"><<a href="mailto:dirk@hohndel.org" target="_blank">dirk@hohndel.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class=""><div class="h5">On Mon, Oct 26, 2015 at 06:13:57PM +1100, Rick Walsh wrote:<br>
> Hi,<br>
><br>
> I cannot build Subsurface with commit 8c70635 Report error received from<br>
> zip_close.<br>
><br>
> I'm not sure where the type zip_error_t is/should be defined.  I'm running<br>
> Fedora 22.<br>
><br>
> [rick@notyourcomputer build]$ make<br>
> [  0%] Built target documentationLink<br>
> [  0%] Built target documentation<br>
> [  0%] Built target link_marble_data<br>
> [  0%] Built target printing_templatesLink<br>
> [  0%] Automatic moc and uic for target subsurface_interface<br>
> [  0%] Built target subsurface_interface_automoc<br>
> [  0%] Built target version<br>
> [  0%] Automatic moc and uic for target subsurface_generated_ui<br>
> [  0%] Built target subsurface_generated_ui_automoc<br>
> [ 15%] Built target subsurface_generated_ui<br>
> [ 16%] Building CXX object<br>
> CMakeFiles/subsurface_interface.dir/qt-ui/subsurfacewebservices.cpp.o<br>
> /home/rick/src/subsurface/qt-ui/subsurfacewebservices.cpp: In member<br>
> function ‘bool DivelogsDeWebServices::prepare_dives_for_divelogs(const<br>
> QString&, bool)’:<br>
> /home/rick/src/subsurface/qt-ui/subsurfacewebservices.cpp:259:3: error:<br>
> ‘zip_error_t’ was not declared in this scope<br>
>    zip_error_t *error = zip_get_error(zip);<br>
>    ^<br>
> /home/rick/src/subsurface/qt-ui/subsurfacewebservices.cpp:259:16: error:<br>
> ‘error’ was not declared in this scope<br>
>    zip_error_t *error = zip_get_error(zip);<br>
>                 ^<br>
> /home/rick/src/subsurface/qt-ui/subsurfacewebservices.cpp:259:41: error:<br>
> ‘zip_get_error’ was not declared in this scope<br>
>    zip_error_t *error = zip_get_error(zip);<br>
>                                          ^<br>
> /home/rick/src/subsurface/qt-ui/subsurfacewebservices.cpp:260:32: error:<br>
> ‘zip_error_code_zip’ was not declared in this scope<br>
>    ze = zip_error_code_zip(error);<br>
>                                 ^<br>
> /home/rick/src/subsurface/qt-ui/subsurfacewebservices.cpp:261:35: error:<br>
> ‘zip_error_code_system’ was not declared in this scope<br>
>    se = zip_error_code_system(error);<br>
>                                    ^<br>
> CMakeFiles/subsurface_interface.dir/build.make:494: recipe for target<br>
> 'CMakeFiles/subsurface_interface.dir/qt-ui/subsurfacewebservices.cpp.o'<br>
> failed<br>
> make[2]: ***<br>
> [CMakeFiles/subsurface_interface.dir/qt-ui/subsurfacewebservices.cpp.o]<br>
> Error 1<br>
> CMakeFiles/Makefile2:1016: recipe for target<br>
> 'CMakeFiles/subsurface_interface.dir/all' failed<br>
> make[1]: *** [CMakeFiles/subsurface_interface.dir/all] Error 2<br>
> Makefile:138: recipe for target 'all' failed<br>
> make: *** [all] Error 2<br>
<br>
</div></div>That's what I get for assuming that libzip has a stable API. Silly, of<br>
course. I'll need to check the specific commit that Lubomir has tested as<br>
known good and see which API is apropriate for this one (and I should<br>
check if there is a way to check at compile time which API is available).<br>
<br></blockquote><div>I thought you'd have learnt by now that no library used by Subsurface has a stable API.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I finally have decent internet - on the flip side I'm now really busy at<br>
the conference :-/<br>
<br>
Thanks for the report<br>
<span class=""><font color="#888888"><br></font></span></blockquote>No worries.<br><br>For what it's worth, I have the version in the F22 repository, 0.11.2-5.fc22.  It appears that libzip v1.0 was released in May this year (first release since 0.11.2 in December 2013), so hopefully that means the API will be more stable from now on, once all the distros catch up.<br><br></div><div class="gmail_quote">Rick<br></div><div class="gmail_quote"><br></div></div></div>