<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 9, 2015 at 11:21 AM, Lubomir I. Ivanov <span dir="ltr"><<a href="mailto:neolit123@gmail.com" target="_blank">neolit123@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">hey Tomaz,<br>
<br>
cmake version 3.2.0-rc2, native Windows.<br>
<br>
with the latest master i get thousands of "undefined references" errors.<br>
<br>
CMakeFiles\facebook_integration.dir/objects.a(facebookconnectwidget.cpp.obj):<br>
In function `ZN15FacebookManager8sendDiveEv':<br>
C:/dev/subsurface/desktop-widgets/plugins/facebook/facebookconnectwidget.cpp:223:<br>
undefined reference to `ProfileWidget2::setToolTipVisibile(bool)'<br>
C:/dev/subsurface/desktop-widgets/plugins/facebook/facebookconnectwidget.cpp:225:<br>
undefined reference to `ProfileWidget2::setToolTipVisibile(bool)'<br>
../../../subsurface-core/libsubsurface_corelib.a(parse-xml.c.obj): In<br>
function `visit_one_node':<br>
C:/dev/subsurface/subsurface-core/parse-xml.c:1852: undefined<br>
reference to `xmlIsBlankNode'<br>
../../../subsurface-core/libsubsurface_corelib.a(parse-xml.c.obj): In<br>
function `preprocess_divelog_de':<br>
C:/dev/subsurface/subsurface-core/parse-xml.c:2005: undefined<br>
reference to `xmlCreateMemoryParserCtxt'<br>
C:/dev/subsurface/subsurface-core/parse-xml.c:2006: undefined<br>
reference to `xmlStringLenDecodeEntities'<br>
../../../subsurface-core/libsubsurface_corelib.a(parse-xml.c.obj): In<br>
function `parse_xml_buffer':<br>
C:/dev/subsurface/subsurface-core/parse-xml.c:2021: undefined<br>
reference to `xmlReadMemory'<br>
C:/dev/subsurface/subsurface-core/parse-xml.c:2032: undefined<br>
reference to `xmlDocGetRootElement'<br>
C:/dev/subsurface/subsurface-core/parse-xml.c:2037: undefined<br>
reference to `xmlFreeDoc'<br>
../../../subsurface-core/libsubsurface_corelib.a(parse-xml.c.obj): In<br>
function `dm4_dive':<br>
<more....><br>
<br>
i saw your recent patch;<br>
"Link the facebook plugin against the subsurface_interface"<br></blockquote><div><br></div><div>Hey<br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
to me it looks like that in my case the facebook module is not linked<br>
both to the core and the desktop-widget modules.<br>
<br>
if set the following in the cmake CMD line:<br>
-DDISABLE_PLUGINS=1 -DFBSUPPORT=1<br>
all is good.<br></blockquote><div><br></div><div>and you get no facebook support.<br><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
any idea what is causing that? perhaps my older cmake...<br></blockquote><div><br></div><div>I don't think it's your old cmake. Dirk also told me that those caused problems on Mac. I think I'll have to reestructure the libsubsurface_core and others to be dynamic because of the plugin, this won't change anything on the programming side besides a few exports.<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
BTW, why did you decide to introduce plugins in Subsurface? are there<br>
benefits over any possible complications that the plugins may<br>
introduce.<br></blockquote><div><br></div><div>yes: it's now simpler to create a new SocialNetwork integration by creating a new plugin for it. think of G+, Diaspora, Instagram, etc.<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
also, unless i'm mistaken, if a plugin is static linked against the<br>
same .a modules that the executable is linked (core, profile,<br>
desktop-widges, etc) aren't we are going to distribute the same code<br>
twice and the plugin size is going to be quite large?<br></blockquote><div><br></div><div>Probably, and maybe this is the reason why it's failing. <br></div><div>Please, continue to compile without facebook integration, I'll try to fix that here by transforming the subsurface_core and subsurface_interface into dynamic libraries.<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
lubomir<br>
--<br></blockquote><div><br></div><div>Other than that - it's easy to revert and not use plugins for subsurface, I liked the code separation that I did but it would work as non-library too. <br></div></div><br></div></div>