<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Feb 20, 2016, at 8:36 PM, Rick Walsh <<a href="mailto:rickmwalsh@gmail.com" class="">rickmwalsh@gmail.com</a>> wrote:</div><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class="">I downloaded and tried 870, and created and edited five dives. The dive details I entered were saved, and uploaded to cloud, and it didn't do anything silly.<br class=""></div></div></div></div></div></blockquote><div><br class=""></div>Good to hear that!</div><div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class="">A little bit of data validation would be nice. One dive was to -20m, another I was breathing 50/60, and another EAN120. Unlikely a real user would enter such values, so not worth holding up a release, but it'd be nice to pick up on impossible values.<br class=""></div></div></div></div></div></blockquote><div><br class=""></div>How did you like EAN120? It should really help with deco.</div><div><br class=""></div><div>Yes, definitely something we should do. I'll need to look into validation functions - I know that QML supports that.</div><div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class="">On one dive, I entered air temperature as 50F, but it was saved as 50C. Entering depth as 60ft, it was correctly converted to 18.3m. My locale is metric.<br class=""></div></div></div></div></div></blockquote><div><br class=""></div>50F to 50C. That's annoying. One is a bit nippy, the other is decidedly too warm...</div><div><br class=""></div><div>Let me stare at that code for a moment... odd, at first glance the code looks like it should work. If the text you entered contains "C" (or actually, QObject::tr("C") - are you running this in a locale where that might be an issue?) then we use C_to_mkelvin(number)... and since we don't have an en_AU translation to begin with and even in that "C" should translate into "C"... hmmm...</div><div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class="">When viewing the dive on the desktop app or <a href="http://cloud.subsurface-divelog.org/" class="">cloud.subsurface-divelog.org</a>, the dodgy gasses were displayed as air, with "Odd gasmix: 1200 O2 0 He" on the desktop terminal output. The dive with negative depth was listed with its negative depth on <a href="http://cloud.subsurface-divelog.org/" class="">cloud.subsurface-divelog.org</a>, but listed as 0m on the desktop app.<br class=""></div></div></div></div></div></blockquote><div><br class=""></div>Giggle. Ok, definitely something that we need to validate better.</div><div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class="">I was a bit disappointed not to be able to delete my bogus dives from Subsurface-mobile. Would that be hard to implement?<br class=""></div></div></div></div></div></blockquote></div><br class=""><div class="">I'm not sure if it's really hard. I just forgot to do it. Adding an option to do so to the context menu shouldn't be too much work.</div><div class=""><br class=""></div><div class="">Thanks for the testing and feedback. Really appreciated.</div><div class=""><br class=""></div><div class="">/D</div></body></html>