<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Rick,<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">Am 02.07.2016 um 09:51 schrieb Robert Helling <<a href="mailto:helling@atdotde.de" class="">helling@atdotde.de</a>>:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">thanks a lot. I will look at this more closely once I have a little bit of time (hopefully this weekend).</span></div></blockquote></div><br class=""></div><div class="">so here are my comments: </div><div class=""><br class=""></div><div class="">In patch 4/5 you do</div><div class=""><br class=""></div><div class="">+<span class="Apple-tab-span" style="white-space: pre;"> </span><span class="Apple-tab-span" style="white-space: pre;"> </span><span class="Apple-tab-span" style="white-space: pre;"> </span>if (((cyl->gasmix.o2.permille == 0) ? O2_IN_AIR : cyl->gasmix.o2.permille) + cyl->gasmix.he.permille > 1000)<br class=""><br class=""></div><div class="">Please do not access the permille’s directly when you are reading. Use get_o2(cal->gasmix) and get_he() instead.</div><div class=""><br class=""></div><div class="">Also, don’t use upper case function names in C code (best_He -> best_he)</div><div class=""><br class=""></div><div class="">Then, there seems to be a problem with rounding (and that might be more what the user expects rather than a mathematical issue): For EAN50 I expect (at least for max_po2=1.6 bar) to get an MOD of 21m. That is what everybody uses. So subsurface should do this as well. In the old MOD calculation we fiddled with the rounding until we did. You should do as well as otherwise users will tell us we cannot do math (even if it’s them).</div><div class=""><br class=""></div><div class="">Then, if we change the depth of the dive, the percentages are not updated. We need the plannerPointsModel send a signal to update the best mixes.</div><div class=""><br class=""></div><div class="">When I set two cylinders to use best mix and then change the max po2, i get an too many gas mixes error.</div><div class=""><br class=""></div><div class="">Finally, there is the question which max pO2 to use. For the „*“ option it should definitely be the bottom one, but for deco mixes I would assume the deco pO2, wouldn’t you?</div><div class=""><br class=""></div><div class="">Best</div><div class="">Robert</div></body></html>