<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-forward-container">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">On 20/11/2016 00:52, Robert Helling
wrote:<br>
</div>
<blockquote
cite="mid:0E4D01C7-3547-4088-87F5-DBD0662724FE@atdotde.de"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
Willem,
<div class=""><br class="">
</div>
<div class="">excellent!</div>
<div class=""><br class="">
<div>
<blockquote type="cite" class="">
<div class="">Am 19.11.2016 um 13:44 schrieb Willem
Ferguson <<a moz-do-not-send="true"
href="mailto:willemferguson@zoology.up.ac.za" class="">willemferguson@zoology.up.ac.za</a>>:</div>
<br class="Apple-interchange-newline">
<div class=""><span style="font-family: Helvetica;
font-size: 12px; font-style: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; widows: auto; word-spacing: 0px;
-webkit-text-stroke-width: 0px; float: none; display:
inline !important;" class="">Please, I need someone to
check my coding carefully. I tested it</span><br
style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows:
auto; word-spacing: 0px; -webkit-text-stroke-width:
0px;" class="">
<span style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows:
auto; word-spacing: 0px; -webkit-text-stroke-width:
0px; float: none; display: inline !important;"
class="">quite extensively and have not found any
problems. Also, there may</span><br
style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows:
auto; word-spacing: 0px; -webkit-text-stroke-width:
0px;" class="">
<span style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows:
auto; word-spacing: 0px; -webkit-text-stroke-width:
0px; float: none; display: inline !important;"
class="">be places where my code is inefficient.</span></div>
</blockquote>
</div>
<br class="">
</div>
<div class="">Looks good from my reading (haven’t tried to build
it yet). Just a few comments:</div>
<div class=""><br class="">
</div>
<div class="">1) You also change the resource name of the
location icon. Is that intentional?</div>
<div class=""><br class="">
</div>
<div class="">2) The picture counting code could probably be
simplified a bit by using the FOR_EACH_PICTURE(dive) macro
that iterates over the pictures of a dive.</div>
<div class=""><br class="">
</div>
<div class="">3) Did you draw the icons yourself? If not, are
the licenses compatible?</div>
<div class=""><br class="">
</div>
<div class="">Best</div>
<div class="">Robert</div>
<br>
</blockquote>
Just a short response. Thank you, Robert, I greatly appreciate
your time.<br>
<br>
The name change of the globe icon was intentional because I
thought that the name "satellite" was highly confusing. There is
an icon in the icons folder, named "satellite" and I thought a
more appropriate name for that resource was needed.<br>
<br>
I will implement the macro and resubmit.<br>
<br>
Yes, they are my own icons. Thank Gimp and Inkscape.<br>
<br>
A few issues:<br>
1) I would like to have the default column width as narrow as
possible by default. The width of 25 specified in divelistview.cpp
appears not to be sufficient. I am not sure?<br>
<br>
2) I could not really think of a good title in the title bar of
the dive list, hence the solid square character. But in the
dropdown list (right-click on title bar) where one can select
fields to be displayed in the dive list, it also lists as the
solid square character: a little unintuitive. I suppose one could
put a decorator there in the same way as in the dive fields below.
But I am not sure what such an icon should look like or whether
such a graphic would show up in the dropdown list? What is your
intuitive feeling?<br>
<br>
Kind regards,<br>
willem<br>
<br>
<br>
<br>
</div>
<br>
</body>
</html>