<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jan 5, 2017, at 8:00 AM, Robert Helling <<a href="mailto:helling@atdotde.de" class="">helling@atdotde.de</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi,<div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On 05 Jan 2017, at 16:48, Robert Helling <<a href="mailto:helling@atdotde.de" class="">helling@atdotde.de</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">or to be more specific: It seems to me that SettingsObjectWrapper::sync() never gets called. And the reason for that might be that there is no call for it anywhere in the code…</div><br class="Apple-interchange-newline"></div></blockquote></div><br class=""></div><div class="">and there is another problem: There seems to be a total confusion between</div><div class=""><br class=""></div><div class="">prefs.deco_mode</div><div class=""><br class=""></div><div class="">and</div><div class=""><br class=""></div><div class="">prefs.display_deco_mode.</div><div class=""><br class=""></div><div class="">The current state is utter non-sense. Tomas, (according to git blame you introduced the latter) could you please explain the meaning of the two and in particular their difference?</div><div class=""><br class=""></div><div class="">Here is my guess: There are two, because one is set in the preferences while the other is a planner parameter. They do the same thing but when chaining the value in the planner, the display of logged dives should not be affected.</div></div></div></blockquote><div><br class=""></div>Yes, that was indeed the logic.</div><div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">So my suggestion would be to resolve this as follows: Rename deco_mode to planner_deco_mode. In all the code, when we need to inquire the current deco mode, we replace the access to the value by a getter that essentially does</div><div class=""><br class=""></div><div class="">currentState == PLAN ? prefs.planner_deco_mode : prefs.display_deco_mode;</div><div class=""><br class=""></div><div class="">What do you think?</div></div></div></blockquote><br class=""></div><div>I think this makes sense.</div><div><br class=""></div><div>/D</div><br class=""></body></html>