<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Actually, I found where sync() is used. In the tests. So NAK from here<div class=""><br class=""></div><div class="">/D</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jan 6, 2017, at 11:53 PM, Tomaz Canabrava <<a href="mailto:tcanabrava@kde.org" class="">tcanabrava@kde.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Ack</div><div class=""><br class=""></div><div class="">They look same </div><div class=""><br class=""><div class="gmail_quote"><div class="">On Sat, 7 Jan 2017 at 04:25, Dirk Hohndel <<a href="mailto:dirk@hohndel.org" class="">dirk@hohndel.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Tomaz,<br class="gmail_msg"><br class=""><br class="gmail_msg"><br class="">this looks good to me. Can I get an ACK for both patches from you?<br class="gmail_msg"><br class=""><br class="gmail_msg"><br class="">/D<br class="gmail_msg"><br class=""><br class="gmail_msg"><br class="">> On Jan 6, 2017, at 2:10 AM, Rick Walsh <<a href="mailto:rickmwalsh@gmail.com" class="gmail_msg" target="_blank">rickmwalsh@gmail.com</a>> wrote:<br class="gmail_msg"><br class="">><br class="gmail_msg"><br class="">> It was never called<br class="gmail_msg"><br class="">><br class="gmail_msg"><br class="">> Signed-off-by: Rick Walsh <<a href="mailto:rickmwalsh@gmail.com" class="gmail_msg" target="_blank">rickmwalsh@gmail.com</a>><br class="gmail_msg"><br class="">> ---<br class="gmail_msg"><br class="">><br class="gmail_msg"><br class="">> As pointed out by Robert<br class="gmail_msg"><br class="">><br class="gmail_msg"><br class="">> core/subsurface-qt/SettingsObjectWrapper.cpp | 29 ----------------------------<br class="gmail_msg"><br class="">> core/subsurface-qt/SettingsObjectWrapper.h | 1 -<br class="gmail_msg"><br class="">> 2 files changed, 30 deletions(-)<br class="gmail_msg"><br class="">><br class="gmail_msg"><br class="">> diff --git a/core/subsurface-qt/SettingsObjectWrapper.cpp b/core/subsurface-qt/SettingsObjectWrapper.cpp<br class="gmail_msg"><br class="">> index 34fe3dd..19fcaaa 100644<br class="gmail_msg"><br class="">> --- a/core/subsurface-qt/SettingsObjectWrapper.cpp<br class="gmail_msg"><br class="">> +++ b/core/subsurface-qt/SettingsObjectWrapper.cpp<br class="gmail_msg"><br class="">> @@ -2315,35 +2315,6 @@ void SettingsObjectWrapper::load()<br class="gmail_msg"><br class="">> s.endGroup();<br class="gmail_msg"><br class="">> }<br class="gmail_msg"><br class="">><br class="gmail_msg"><br class="">> -void SettingsObjectWrapper::sync()<br class="gmail_msg"><br class="">> -{<br class="gmail_msg"><br class="">> - QSettings s;<br class="gmail_msg"><br class="">> - s.beginGroup("Planner");<br class="gmail_msg"><br class="">> - s.setValue("last_stop", prefs.last_stop);<br class="gmail_msg"><br class="">> - s.setValue("verbatim_plan", prefs.verbatim_plan);<br class="gmail_msg"><br class="">> - s.setValue("display_duration", prefs.display_duration);<br class="gmail_msg"><br class="">> - s.setValue("display_runtime", prefs.display_runtime);<br class="gmail_msg"><br class="">> - s.setValue("display_transitions", prefs.display_transitions);<br class="gmail_msg"><br class="">> - s.setValue("safetystop", prefs.safetystop);<br class="gmail_msg"><br class="">> - s.setValue("reserve_gas", prefs.reserve_gas);<br class="gmail_msg"><br class="">> - s.setValue("ascrate75", prefs.ascrate75);<br class="gmail_msg"><br class="">> - s.setValue("ascrate50", prefs.ascrate50);<br class="gmail_msg"><br class="">> - s.setValue("ascratestops", prefs.ascratestops);<br class="gmail_msg"><br class="">> - s.setValue("ascratelast6m", prefs.ascratelast6m);<br class="gmail_msg"><br class="">> - s.setValue("descrate", prefs.descrate);<br class="gmail_msg"><br class="">> - s.setValue("bottompo2", prefs.bottompo2);<br class="gmail_msg"><br class="">> - s.setValue("decopo2", prefs.decopo2);<br class="gmail_msg"><br class="">> - s.setValue("bestmixend", <a href="http://prefs.bestmixend.mm/" rel="noreferrer" class="gmail_msg" target="_blank">prefs.bestmixend.mm</a>);<br class="gmail_msg"><br class="">> - s.setValue("doo2breaks", prefs.doo2breaks);<br class="gmail_msg"><br class="">> - s.setValue("drop_stone_mode", prefs.drop_stone_mode);<br class="gmail_msg"><br class="">> - s.setValue("switch_at_req_stop", prefs.switch_at_req_stop);<br class="gmail_msg"><br class="">> - s.setValue("min_switch_duration", prefs.min_switch_duration);<br class="gmail_msg"><br class="">> - s.setValue("bottomsac", prefs.bottomsac);<br class="gmail_msg"><br class="">> - s.setValue("decosac", prefs.decosac);<br class="gmail_msg"><br class="">> - s.setValue("deco_mode", int(prefs.deco_mode));<br class="gmail_msg"><br class="">> - s.endGroup();<br class="gmail_msg"><br class="">> -}<br class="gmail_msg"><br class="">> -<br class="gmail_msg"><br class="">> SettingsObjectWrapper* SettingsObjectWrapper::instance()<br class="gmail_msg"><br class="">> {<br class="gmail_msg"><br class="">> static SettingsObjectWrapper settings;<br class="gmail_msg"><br class="">> diff --git a/core/subsurface-qt/SettingsObjectWrapper.h b/core/subsurface-qt/SettingsObjectWrapper.h<br class="gmail_msg"><br class="">> index 7fdd104..67fc6ac 100644<br class="gmail_msg"><br class="">> --- a/core/subsurface-qt/SettingsObjectWrapper.h<br class="gmail_msg"><br class="">> +++ b/core/subsurface-qt/SettingsObjectWrapper.h<br class="gmail_msg"><br class="">> @@ -715,7 +715,6 @@ public:<br class="gmail_msg"><br class="">> UpdateManagerSettings *update_manager_settings;<br class="gmail_msg"><br class="">> DiveComputerSettings *dive_computer_settings;<br class="gmail_msg"><br class="">><br class="gmail_msg"><br class="">> - void sync();<br class="gmail_msg"><br class="">> void load();<br class="gmail_msg"><br class="">> private:<br class="gmail_msg"><br class="">> SettingsObjectWrapper(QObject *parent = NULL);<br class="gmail_msg"><br class="">> --<br class="gmail_msg"><br class="">> 2.9.3<br class="gmail_msg"><br class="">><br class="gmail_msg"><br class="">> _______________________________________________<br class="gmail_msg"><br class="">> subsurface mailing list<br class="gmail_msg"><br class="">> <a href="mailto:subsurface@subsurface-divelog.org" class="gmail_msg" target="_blank">subsurface@subsurface-divelog.org</a><br class="gmail_msg"><br class="">> <a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface</a><br class="gmail_msg"><br class=""><br class="gmail_msg"><br class=""></blockquote></div></div>
</div></blockquote></div><br class=""></div></body></html>