<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 22 February 2017 at 20:14, Stefan Fuchs <span dir="ltr"><<a href="mailto:sfuchs@gmx.de" target="_blank">sfuchs@gmx.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    <p>Hallo Dirk, hallo Joachim,<br>
    </p><span class="">
    Am 22.02.2017 um 00:10 schrieb Dirk Hohndel:<br>
    <blockquote type="cite">
      <div><br>
        <blockquote type="cite">
          <div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);float:none;display:inline!important">For the moment I have to stop here
              because I will be on holiday for a week soon and this part
              for sure will need approximately 1-3 years development
              time on my side ;-)</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)">
            <br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)">
            <span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);float:none;display:inline!important">What do you think about the part of
              the minim gas calculation we created up to now?</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)">
            <span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);float:none;display:inline!important">Is it already time to do a pull
              request to maybe have some deeper testing or do we need to
              continue testing and review internally?</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)">
          </div>
        </blockquote>
        <div><br>
        </div>
        <div>I'd like to ask that anything that is submitted for master
          has had some review and testing, comes with an automated test
          or two and most importantly tries to be as non-invasive as
          possible.</div>
        <br>
      </div>
    </blockquote></span>
    Automated tests? Well, that means another +2 years of development
    time on my side ;-)<br>
    <br>
    Just kidding... I will try to learn how this works after my holiday.
    BTW: Joachim, could you have a look into this as well?<span class=""><br></span></div></blockquote><div><br></div><div>Stefan, Joachim,<br><br></div><div>tests/testplan.cpp is where the existing planner tests are.  This would be a good starting place as it shows how to set up preferences and define a dive to test.  In fact, you could probably modify the existing dive tests to add a test for expected minimum gas results.<br><br></div><div>Cheers,<br><br></div><div>Rick<br></div></div></div></div>