<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Hi Dirk,<br>
</p>
Am 16.03.2017 um 18:55 schrieb Dirk Hohndel:<br>
<blockquote
cite="mid:D047832A-357F-4222-905B-2AE34E58A013@hohndel.org"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Mar 16, 2017, at 10:25 AM, Stefan Fuchs <<a
moz-do-not-send="true" href="mailto:sfuchs@gmx.de"
class="">sfuchs@gmx.de</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<p style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255);" class="">Hi All,</p>
<p style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255);" class="">currently I try to learn how
the automatic tests work :-)<br class="">
I think I almost understood what I have to do to add
automatic tests for the minimum gas calculation but I
first have a few general questions:</p>
<p style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255);" class="">- In linux build building
the tests is ON by default, in mxe build it is OFF. Could
we switch this ON there by default as well?</p>
</div>
</blockquote>
<div><br class="">
</div>
This is simply a CMake variable - so your build script can pass
in ON or </div>
<div>OFF as you want.<br class="">
</div>
</blockquote>
Yes, this is what the mxe-based-build.sh is doing. But it is hard
coded to OFF inside the script. I was wondering if we can (should?)
change this to ON to be in line with the default for the linux build
which is ON.<br>
<a class="moz-txt-link-freetext" href="https://github.com/Subsurface-divelog/subsurface/blob/master/packaging/windows/mxe-based-build.sh#L299">https://github.com/Subsurface-divelog/subsurface/blob/master/packaging/windows/mxe-based-build.sh#L299</a><br>
<br>
<blockquote
cite="mid:D047832A-357F-4222-905B-2AE34E58A013@hohndel.org"
type="cite">
<div>
<blockquote type="cite" class="">
<div class="">
<p style="font-family: Helvetica; font-size: 12px;
font-style: normal; font-variant-caps: normal;
font-weight: normal; letter-spacing: normal; orphans:
auto; text-align: start; text-indent: 0px; text-transform:
none; white-space: normal; widows: auto; word-spacing:
0px; -webkit-text-stroke-width: 0px; background-color:
rgb(255, 255, 255);" class="">- My assumption is that if
building tests is ON, the tests will be run as well during
build. For linux this should work immediately. For mxe
build I need wine to run the windows exe files. I
installed wine and in fact I can now run the exe tests
under linux. But I'm still not sure if they are
automatically run during build (both linux and MXE). Where
will the test results go? There is nothing in build.log or
winbuild.log or stdout.</p>
</div>
</blockquote>
<br class="">
</div>
<div>Tests are NOT automatically run when doing a build - and I'd
find this </div>
<div>extremely annoying when I'm working on a feature, TBH.</div>
</blockquote>
Yes, you're right. For me this would be even worse with my slow HW
;-(<br>
My misunderstanding comes from reading these lines:<br>
<a class="moz-txt-link-freetext" href="https://github.com/Subsurface-divelog/subsurface/blob/master/tests/CMakeLists.txt#L66">https://github.com/Subsurface-divelog/subsurface/blob/master/tests/CMakeLists.txt#L66</a><br>
I thought this is preparing to run the tests during build because it
checks for wine? Or is this obsolete? Or am I simply not reading
this correctly?<br>
<br>
Best regards<br>
Stefan<br>
<br>
<div class="moz-signature">-- <br>
<meta http-equiv="CONTENT-TYPE" content="text/html;
charset=windows-1252">
<title></title>
<meta name="GENERATOR" content="OpenOffice.org 3.3 (Win32)">
<meta name="CREATED" content="0;0">
<meta name="CHANGEDBY" content="Stefan Fuchs">
<meta name="CHANGED" content="20120503;23115492">
<style type="text/css">
<!--
P { color: #000000 }
-->
</style>
<p>Stefan Fuchs<br>
E-Mail: <a href="mailto:sfuchs@gmx.de">sfuchs@gmx.de</a></p>
</div>
</body>
</html>