<div dir="ltr"><span style="font-size:12.8px">Hey Stefan,</span><div dir="auto" style="font-size:12.8px"><br></div><div dir="auto" style="font-size:12.8px">The rules you mentioned do add tests, but not as part of the build itself, there is a different target called "check" that can be used to run the tests. Up to recently, some tests were failing under windows, this is why the mxe build script did no enable them. Tests are now passing; I though about enabling them together with enabling mxe build and tests in CI. Unfortunately I was quite busy the last weeks and did not have much time to make progress in this area... (Or to answer your questions, sorry for the late reply)</div><div dir="auto" style="font-size:12.8px"><br></div><div dir="auto" style="font-size:12.8px">Cheers,</div><div dir="auto" style="font-size:12.8px"><br></div><div dir="auto" style="font-size:12.8px">Jeremie</div></div><div class="gmail_extra"><br><div class="gmail_quote">2017-03-17 1:36 GMT+07:00 Stefan Fuchs <span dir="ltr"><<a href="mailto:sfuchs@gmx.de" target="_blank">sfuchs@gmx.de</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<p>Hi Dirk,<br>
</p><span class="">
Am 16.03.2017 um 18:55 schrieb Dirk Hohndel:<br>
<blockquote type="cite">
<br>
<div>
<blockquote type="cite">
<div>On Mar 16, 2017, at 10:25 AM, Stefan Fuchs <<a href="mailto:sfuchs@gmx.de" target="_blank">sfuchs@gmx.de</a>> wrote:</div>
<br class="m_-1010059256897901663Apple-interchange-newline">
<div>
<p style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)">Hi All,</p>
<p style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)">currently I try to learn how
the automatic tests work :-)<br>
I think I almost understood what I have to do to add
automatic tests for the minimum gas calculation but I
first have a few general questions:</p>
<p style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)">- In linux build building
the tests is ON by default, in mxe build it is OFF. Could
we switch this ON there by default as well?</p>
</div>
</blockquote>
<div><br>
</div>
This is simply a CMake variable - so your build script can pass
in ON or </div>
<div>OFF as you want.<br>
</div>
</blockquote></span>
Yes, this is what the mxe-based-build.sh is doing. But it is hard
coded to OFF inside the script. I was wondering if we can (should?)
change this to ON to be in line with the default for the linux build
which is ON.<br>
<a class="m_-1010059256897901663moz-txt-link-freetext" href="https://github.com/Subsurface-divelog/subsurface/blob/master/packaging/windows/mxe-based-build.sh#L299" target="_blank">https://github.com/Subsurface-<wbr>divelog/subsurface/blob/<wbr>master/packaging/windows/mxe-<wbr>based-build.sh#L299</a><span class=""><br>
<br>
<blockquote type="cite">
<div>
<blockquote type="cite">
<div>
<p style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)">- My assumption is that if
building tests is ON, the tests will be run as well during
build. For linux this should work immediately. For mxe
build I need wine to run the windows exe files. I
installed wine and in fact I can now run the exe tests
under linux. But I'm still not sure if they are
automatically run during build (both linux and MXE). Where
will the test results go? There is nothing in build.log or
winbuild.log or stdout.</p>
</div>
</blockquote>
<br>
</div>
<div>Tests are NOT automatically run when doing a build - and I'd
find this </div>
<div>extremely annoying when I'm working on a feature, TBH.</div>
</blockquote></span>
Yes, you're right. For me this would be even worse with my slow HW
;-(<br>
My misunderstanding comes from reading these lines:<br>
<a class="m_-1010059256897901663moz-txt-link-freetext" href="https://github.com/Subsurface-divelog/subsurface/blob/master/tests/CMakeLists.txt#L66" target="_blank">https://github.com/Subsurface-<wbr>divelog/subsurface/blob/<wbr>master/tests/CMakeLists.txt#<wbr>L66</a><br>
I thought this is preparing to run the tests during build because it
checks for wine? Or is this obsolete? Or am I simply not reading
this correctly?<span class=""><br>
<br>
Best regards<br>
Stefan<br>
<br>
<div class="m_-1010059256897901663moz-signature">-- <br>
<p>Stefan Fuchs<br>
E-Mail: <a href="mailto:sfuchs@gmx.de" target="_blank">sfuchs@gmx.de</a></p>
</div>
</span></div>
<br>______________________________<wbr>_________________<br>
subsurface mailing list<br>
<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.<wbr>org</a><br>
<a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" rel="noreferrer" target="_blank">http://lists.subsurface-<wbr>divelog.org/cgi-bin/mailman/<wbr>listinfo/subsurface</a><br>
<br></blockquote></div><br></div>