<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 20-03-17 21:32, Rick Walsh wrote:<br>
</div>
<blockquote
cite="mid:CAF+v9JuPMVGYKeZsWUHAKsLBnwHERT960SpaVMva_7FqRiZL9A@mail.gmail.com"
type="cite">
<div dir="auto">
<div><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On 20 Mar 2017 06:35, "Dirk
Hohndel" <<a moz-do-not-send="true"
href="mailto:dirk@hohndel.org">dirk@hohndel.org</a>>
wrote:<br type="attribution">
<blockquote class="quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="quoted-text"><br>
> On Mar 18, 2017, at 5:10 PM, Dirk Hohndel <<a
moz-do-not-send="true"
href="mailto:dirk@hohndel.org">dirk@hohndel.org</a>>
wrote:<br>
><br>
> I spent a day trying to fix the selection bug in
Subsurface-mobile that<br>
> Willem and others have reported. When you tap on
a dive in the dive list,<br>
> you often (but not always) get the next dive down
the list (i.e., the dive<br>
> one before the dive that you wanted, given the
ordering of the dive list).<br>
><br>
> In the process I think I managed to clean up some
of the code and remove<br>
> some obsolete code, but unfortunately the problem
itself still isn't<br>
> fixed. Certain cases that used to reliably fail
now work at times, but it<br>
> still isn't "simply correct".<br>
><br>
> I thought I understood how our use of the QML
ListView works, and I'm<br>
> baffled why the wrong item is shown. Printing
debug output isn't all that<br>
> helpful because this is not a procedural
language, so it's hard to make<br>
> sure that the debug code actually runs when you
want it to run.<br>
><br>
> Any help would be welcome. I'm running out of
time today, I'll try to make<br>
> new beta apps for Android and iOS so people can
test.<br>
<br>
</div>
A new Android apk is in daily: <a
moz-do-not-send="true"
href="http://subsurface-divelog.org/downloads/daily/Subsurface-mobile-4.6.3.132-arm.apk"
rel="noreferrer" target="_blank">http://subsurface-divelog.org/<wbr>downloads/daily/Subsurface-<wbr>mobile-4.6.3.132-arm.apk</a></blockquote>
</div>
</div>
</div>
<div dir="auto"><br>
</div>
<div dir="auto">I've tested that daily a little. On my Samsung
Galaxy s6.</div>
<div dir="auto">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
I also have a new iOS build, but that I need to send to
the Beta channel<br>
because I can't create a .ipa that will install on a
random iOS device (thanks,<br>
Apple). Then again, we have only ~250 users on iOS, so
this isn't really<br>
a popular platform for us.<br>
<br>
In my testing so far I see two major differences:<br>
<br>
a) it seems to reliably show the correct dive (good)<br>
</blockquote>
</div>
</div>
</div>
<div dir="auto">I'm reliably shown the correct dive.</div>
<div dir="auto"><br>
</div>
<div dir="auto">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
b) when you tap on a dive that's later in time, it
sometimes renders ALL<br>
of the dives (in the background) and seems to be hung
for a long time<br>
(depending on how many dives are in your dive list, I
guess), before<br>
it finally shows the right one (REALLY bad)<br>
</blockquote>
</div>
</div>
</div>
<div dir="auto">I can't reproduce that.</div>
<div dir="auto">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
I guess that's progress? Not sure.<br>
<br>
Testing and help in fixing the problem would be very
welcome<br>
</blockquote>
</div>
</div>
</div>
<div dir="auto">I'm not able to do any fixing at the moment but
happy to test when I get the chance.</div>
<div dir="auto"><br>
</div>
<div dir="auto">A couple of small but annoying bugs I noticed:</div>
<div dir="auto">In editing dive notes, the Android keyboard
never automatically capitalizes the first letter of a
sentence. In other apps it does. Not sure if this can be
changed in qml.</div>
<div dir="auto"><br>
</div>
<div dir="auto">The back button from the gps preferences
(possibly some other pages too) doesn't work. Hit it a second
time and the app closes.</div>
<div dir="auto"><br>
</div>
</div>
</blockquote>
<p>It is really weird that I can reproduce these issues, and Rick
can not. I suspect some timing issues involved, as I am testing
on a phone that less powerful than Rick uses. <br>
</p>
<p>For the record: I first test on the desktop compiled for mobile,
and finally verify on the phone. Up to now, I have not found any
differences between these platforms, but obviously, there are
differences (like screensize and not having rotate sensors on the
desktop).</p>
<p>This all being said. I just did a pull request (#275) that solves
the enumerate loop, and in addition the issue #263, and different
dive shown than selected. Al least, It solves it for me, but
boarder testing is required, as it it still a mystery.</p>
<p>best,<br>
</p>
<p>--jan<br>
</p>
</body>
</html>