<html><head></head><body><div dir="auto">Yes, that sounds good. Just drop those two classes<br><br></div>
<div dir="auto"><!-- tmjah_g_1299s -->-- <!-- tmjah_g_1299e --><br></div>
<div dir="auto"><!-- tmjah_g_1299s -->From my phone<!-- tmjah_g_1299e --></div>
<div style="font-size:10.0pt;font-family:"Tahoma","sans-serif";padding:3.0pt 0in 0in 0in">
<hr style="border:none;border-top:solid #E1E1E1 1.0pt">
<b>From:</b> Marco Martin <notmart@gmail.com><br>
<b>Sent:</b> Fri Mar 31 15:20:26 GMT+02:00 2017<br>
<b>To:</b> Dirk Hohndel <dirk@hohndel.org><br>
<b>Cc:</b> subsurface@subsurface-divelog.org<br>
<b>Subject:</b> Re: [PATCH] subsurface-mobile: fixes to dive edit view, post most of things to QtQuickcontrols2<br>
</dirk@hohndel.org></notmart@gmail.com></div>
<br>
<pre class="blue">On Friday 31 March 2017 15:05:12 Dirk Hohndel wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> Yes - that's pretty much what it is. I don't think I know how to implement<br> that. Can you point me at a starting point...<br></blockquote><br>i can give it a try and update the patch<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> * downloadfromdivecomputer.qml is not ported, as it didn't seem to be used<br> at all in the app?<br></blockquote> <br> Willem is working on implementing that, but got stalled. I'm sure that he<br> would love some pointers to get that part going.<br></blockquote><br>I can port blindly that file then<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #ad7fa8; padding-left: 1ex;"> * StyledTextField and subsurfacebutton components would go, making code a<br> bit simpler (in qqc2 they are styled more android-like, is still possible<br> to write a text field styled completely different, if needed)<br></blockquote> <br> I'm not quite sure what you mean by that...<br></blockquote><br>I mean, as far i understood, those two classes were created to make the text <br>edit and the button more android looking, but stock qtquickcontrols2 ones <br>seems pretty good already, so dropping those 2 classes, simplifies things a bit<br></pre></body></html>