<div dir="ltr">Willem,<br><br><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 7, 2017 at 11:29 AM, Tomaz Canabrava <span dir="ltr"><<a href="mailto:tcanabrava@kde.org" target="_blank">tcanabrava@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Fri, Apr 7, 2017 at 8:03 AM, Willem Ferguson <span dir="ltr"><<a href="mailto:willemferguson@zoology.up.ac.za" target="_blank">willemferguson@zoology.up.ac.<wbr>za</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On 07/04/2017 03:45, Dirk Hohndel wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>
Just a quick heads-up, I just triggered new daily builds of the desktop<br>
version... this includes Tomaz' rewrite of some of the code implementing<br>
the maintab (it moves Info, Extra Info, Statistics, and Photos into<br>
separate files.<br>
<br>
I reviewed the code and did quite a bit of testing. I haven't been able to<br>
spot anything that got broken. But I'd appreciate if people could take a<br>
close look and make sure I didn't miss anything there...<br>
<br>
Thanks<br>
<br>
/D<br></span>
/home/willem/src/subsurface/de<wbr>sktop-widgets/tab-widgets/TabD<wbr>iveInformation.cpp: In member function ‘virtual void TabDiveInformation::updateData<wbr>()’:<br>
</blockquote>
<br>
<br>
When building, I get:<br>
<br>
/home/willem/src/subsurface/de<wbr>sktop-widgets/tab-widgets/TabD<wbr>iveInformation.cpp:69:15: warning: conversion to ‘int’ from ‘double’ may alter its value [-Wfloat-conversion]<br>
sac.mliter = gases[i].mliter / (depth_to_atm(mean[i], &displayed_dive) * duration[i] / 60);<br>
^<br>
/home/willem/src/subsurface/de<wbr>sktop-widgets/tab-widgets/TabD<wbr>ivePhotos.cpp: In member function ‘virtual void TabDivePhotos::contextMenuEven<wbr>t(QContextMenuEvent*)’:<br>
/home/willem/src/subsurface/de<wbr>sktop-widgets/tab-widgets/TabD<wbr>ivePhotos.cpp:45:91: error: no matching function for call to ‘QMenu::addAction(QString, TabDivePhotos*, void (TabDivePhotos::*)())’<br>
popup.addAction(tr("Load image(s) from file(s)"), this, &TabDivePhotos::addPhotosFromF<wbr>ile);<br>
^<br>
In file included from /usr/include/x86_64-linux-gnu/<wbr>qt5/QtWidgets/QMenu:1:0,<br>
from /home/willem/src/subsurface/de<wbr>sktop-widgets/tab-widgets/TabD<wbr>ivePhotos.cpp:8:<br>
/usr/include/x86_64-linux-gnu/<wbr>qt5/QtWidgets/qmenu.h:76:14: note: candidate: QAction* QMenu::addAction(const QString&)<br>
QAction *addAction(const QString &text);<br>
^<br>
/usr/include/x86_64-linux-gnu/<wbr>qt5/QtWidgets/qmenu.h:76:14: note: candidate expects 1 argument, 3 provided<br>
<br>
Clearly there is a Qt problem. Although I have installed Qt 5.7 I get:<br>
<br>
$ qmake --version<br>
<br>
QMake version 3.0<br>
Using Qt version 5.5.1 in /usr/lib/x86_64-linux-gnu<br>
<br>
Do I need to re-install Qt ??<br></blockquote></div></div></div></div></div></blockquote><div><br></div><div>One of the things I want to add for subsurface depends on Qt Charts, that was released for Qt 5.7<br></div><div>Dirk, This is okay?<br><br></div><div>Tomaz<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"></blockquote><div><br></div></div></div><div>No, I'll provide a patch to fix this, sorry for the noise.<br> <br></div><span class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Kind regards,<br>
<br>
willem<div class="m_-5267789689587105121HOEnZb"><div class="m_-5267789689587105121h5"><br>
<br>
<br>
______________________________<wbr>_________________<br>
subsurface mailing list<br>
<a href="mailto:subsurface@subsurface-divelog.org" target="_blank">subsurface@subsurface-divelog.<wbr>org</a><br>
<a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" rel="noreferrer" target="_blank">http://lists.subsurface-divelo<wbr>g.org/cgi-bin/mailman/listinfo<wbr>/subsurface</a><br>
</div></div></blockquote></span></div><br></div></div>
</blockquote></div><br></div></div>