<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On 14 Jul. 2017 03:47, "Martin de Weger" <<a href="mailto:martin@reef-it.nl">martin@reef-it.nl</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div name="messageBodySection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif">Hi Rick,
<div><br></div>
<div>Could you please mail me the 5 line instructions? I’m trying to make myself useful and try to work on things, but I have “issues” with GitHub. :/</div>
<div></div></div></div></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Hi Martin,</div><div dir="auto"><br></div><div dir="auto">Here's Dirk's email from when I emailed my last patch.</div><div dir="auto"><br></div><div dir="auto"><span style="font-family:sans-serif">On 22 Jun. 2017 21:48, "Dirk Hohndel" <<a href="mailto:dirk@hohndel.org">dirk@hohndel.org</a>> wrote:</span><br style="font-family:sans-serif"><blockquote style="font-family:sans-serif;margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Obviously correct patch. Duh.<br><div><br>> On Jun 22, 2017, at 2:22 AM, Rick Walsh <<a href="mailto:rickmwalsh@gmail.com">rickmwalsh@gmail.com</a>> wrote:<br>><br>> Signed-off-by: Rick Walsh <<a href="mailto:rickmwalsh@gmail.com">rickmwalsh@gmail.com</a>><br>> ---<br>> I will try to work out how to do GitHub pull requests<br><br></div>I'm happy to take things like this as patches, Rick.<br><br>But creating a pull request is really easy.<br>You need a GitHub account.<br>Fork the Subsurface-divelog/subsurface repo<br>Create a local branch<br>git checkout -b forDirk<br>add the commit there<br>git push <a href="https://github.com/">https://github.com/</a><<wbr>yourGitHubID>/subsurface forDirk<br>enter your login and password<br>now on the website navigate to that branch<br>there will be a button to create the pull request.<br></blockquote></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><blockquote style="font-family:sans-serif;margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"></blockquote></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div name="messageBodySection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif"><div><br></div>
</div><div class="elided-text">
<div name="messageReplySection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif"><br>
On 13 jul. 2017 13:35 +0200, Tomaz Canabrava <<a href="mailto:tcanabrava@kde.org" target="_blank">tcanabrava@kde.org</a>>, wrote:<br>
<blockquote type="cite" style="margin:5px 5px;padding-left:10px;border-left:thin solid #1abc9c">
<div>
<div dir="auto">On it</div>
<div dir="auto"></div></div></blockquote></div></div></div></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">Thank you very much Tomaz.</div><div dir="auto"><br></div><div dir="auto">Cheers,</div><div dir="auto"><br></div><div dir="auto">Rick</div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="elided-text"><div name="messageReplySection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif"><blockquote type="cite" style="margin:5px 5px;padding-left:10px;border-left:thin solid #1abc9c"><div><div dir="auto"><br></div>
<br>
<div class="gmail_quote">
<div>On Thu 13. Jul 2017 at 13:35, Tomaz Canabrava <<a href="mailto:tcanabrava@kde.org" target="_blank">tcanabrava@kde.org</a>> wrote:<br></div>
<blockquote class="gmail_quote" style="margin:5px 5px;padding-left:10px;border-left:thin solid #e67e22">
<div>
<div dir="auto"><br></div>
<br>
<div class="gmail_quote">
<div>On Thu 13. Jul 2017 at 13:14, Rick Walsh <<a href="mailto:rickmwalsh@gmail.com" target="_blank">rickmwalsh@gmail.com</a>> wrote:<br></div>
<blockquote class="gmail_quote" style="margin:5px 5px;padding-left:10px;border-left:thin solid #3498db">
<div>
<div>
<div>
<div>
<div>
<div>
<div>Hi,<br></div>
<div><br>
With one of the greatest features of Subsurface-mobile, downloading from dive computers becoming a reality (and way beyond my knowledge to be contributing to the code there), and some spare time in airports and hotel rooms thanks to working away from home for a few weeks, I thought I'd try to tackle that other Subsurface feature that's missing from the app. While plenty of users will ignore it, it is far beyond a toy or curiosity, and a powerful mobile dive planner will be very handy to those that want it.<br>
<br></div>
How hard could it be? I asked myself. The UI side of things is tedious but actually not too difficult. I won't say it's a work of art, but it should be functional. But now I'm stuck - I haven't managed to work out how to integrate the Qt models, CylindersModel and DivePlannerPointsModel, with the QML side of things, and I don't know how to call the code that does the actual planning. I understand what the UI does, and I understand the C code, but the magic in between is lost on me.<br>
<br></div>
I pushed my work to GitHub (thanks Dirk, your 5 line instructions a month or so ago was far more helpful than any guide I found online), but this should not go into Master just before a major Subsurface-mobile release.<br></div>
<br>
<a href="https://github.com/RickMWalsh/subsurface/tree/mobilePlanner" target="_blank">https://github.com/RickMWalsh/<wbr>subsurface/tree/mobilePlanner</a><br>
<br></div>
So, would someone with Qt knowledge be able to take a look and either (a) let me know how to link the QML and Qt, or (b) do it themselves? It builds and runs just fine on the desktop, so no need to create an apk just to test it.<br>
<br></div>
Thanks,<br>
<br></div>
Rick<br></div>
______________________________<wbr>_________________<br>
subsurface mailing list<br>
<a href="mailto:subsurface@subsurface-divelog.org" target="_blank">subsurface@subsurface-divelog.<wbr>org</a><br>
<a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" rel="noreferrer" target="_blank">http://lists.subsurface-<wbr>divelog.org/cgi-bin/mailman/<wbr>listinfo/subsurface</a><br></blockquote>
</div>
</div>
</blockquote>
</div>
</div>
______________________________<wbr>_________________<br>
subsurface mailing list<br>
<a href="mailto:subsurface@subsurface-divelog.org" target="_blank">subsurface@subsurface-divelog.<wbr>org</a><br>
<a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" target="_blank">http://lists.subsurface-<wbr>divelog.org/cgi-bin/mailman/<wbr>listinfo/subsurface</a><br></blockquote>
</div>
</div></div>
</blockquote></div><br></div></div></div>