<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hello All,<br>
</p>
Am 18.09.2017 um 22:48 schrieb Stefan Fuchs:<br>
<blockquote type="cite"
cite="mid:4679a0b4-25b4-0a81-2496-7571c6493633@gmx.de">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<p>Hi Robert, hi Tomaz,<br>
</p>
<br>
<div class="moz-cite-prefix">Am 09.09.2017 um 22:11 schrieb Stefan
Fuchs:<br>
</div>
<blockquote type="cite"
cite="mid:0f562dd0-e562-cb52-8089-c50469e40945@gmx.de">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
Am 30.08.2017 um 19:45 schrieb Robert Helling:<br>
<blockquote type="cite"
cite="mid:1952EA94-C423-45DF-A0A0-2683540B0F4D@atdotde.de">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On 30. Aug 2017, at 10:18, Tomaz Canabrava
<<a href="mailto:tcanabrava@kde.org" class=""
moz-do-not-send="true">tcanabrava@kde.org</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" class="">Robert,<br class="">
<br class="">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0
0 .8ex;border-left:1px #ccc
solid;padding-left:1ex"> What is still missing:<br
class="">
A ui element to turn this expensive calculation
off.<br class="">
</blockquote>
<div class=""><br class="">
</div>
<div class="">This is easy to add, wouldn't take
me much time.</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</div>
</blockquote>
<p>I have a finding here which may be related to this discussion
about long calculation times for Roberts new feature and the
questions about plan() being called multiple times:</p>
<p>Since Roberts change here on my side not only the calculation
of the plan takes much longer but also this happens:<br>
If I increase or decrease any QSpinBox value in the planner
preferences by clicking on the up or down arrow the QSpinBox
value is increased/decreased by two steps instead of one. This
happens with any QSpinBox based value like gas options, ascent
rates, VPM conservatism,...</p>
<p>I don't believe this really comes from Roberts change but it
was maybe revealed by it.</p>
<p>Can you reproduce this?</p>
</blockquote>
I found a hint how this double increment/decrement issue of the
QSpinBoxes could be explained:<br>
<a class="moz-txt-link-freetext"
href="https://github.com/MRtrix3/mrtrix3/issues/306"
moz-do-not-send="true">https://github.com/MRtrix3/mrtrix3/issues/306</a><br>
<br>
So beside the fact that I up to now do not like these long
calculation times after each parameter change that much (I guess
it's the same for Robert himself) I would recommend the following
regarding the UI controls:<br>
[...]<br>
- Turn off the mouse button hold causes repeated in/decrease
feature of each QSpinBox. No clue yet how this can be done.<br>
<br>
</blockquote>
Found even a second reference on the web and maybe a better
solution:<br>
<a class="moz-txt-link-freetext" href="https://github.com/manisandro/gImageReader/issues/37">https://github.com/manisandro/gImageReader/issues/37</a><br>
<br>
Maybe we should indeed disable most of the planner UI elements while
the calculations are performed and enable them again after they are
finished. I would love to test this but once again recognized that I
have almost no object oriented programming skills at all... :-(<br>
<br>
How can I call <span class="pl-en">PlannerSettingsWidget::disableDecoElements
(in fact later-on a modified variant)</span><br>
<a class="moz-txt-link-freetext" href="https://github.com/Subsurface-divelog/subsurface/blob/master/desktop-widgets/diveplanner.cpp#L250">https://github.com/Subsurface-divelog/subsurface/blob/master/desktop-widgets/diveplanner.cpp#L250</a><br>
<br>
from somewhere here in <span class="pl-en">DivePlannerPointsModel::createPlan</span><br>
<a class="moz-txt-link-freetext" href="https://github.com/Subsurface-divelog/subsurface/blob/master/qt-models/diveplannermodel.cpp#L986">https://github.com/Subsurface-divelog/subsurface/blob/master/qt-models/diveplannermodel.cpp#L986</a><br>
<br>
Best regards<br>
Stefan<br>
<br>
<div class="moz-signature">-- <br>
<meta http-equiv="CONTENT-TYPE" content="text/html; charset=utf-8">
<title></title>
<meta name="GENERATOR" content="OpenOffice.org 3.3 (Win32)">
<meta name="CREATED" content="0;0">
<meta name="CHANGEDBY" content="Stefan Fuchs">
<meta name="CHANGED" content="20120503;23115492">
<style type="text/css">
<!--
P { color: #000000 }
-->
</style>
<p>Stefan Fuchs<br>
E-Mail: <a href="mailto:sfuchs@gmx.de">sfuchs@gmx.de</a></p>
</div>
</body>
</html>