<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Linus,<br>
</p>
Am 20.09.2017 um 10:16 schrieb Stefan Fuchs:<br>
<blockquote type="cite"
cite="mid:1a21ac59-c5dd-000a-fa92-abe00eb4667d@gmx.de">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<blockquote type="cite"
cite="mid:CA+55aFz07TCZ2MDy=jiGU+0hFLbJ8jFBZRv_xKJCwOA1pcXDxw@mail.gmail.com">
<pre wrap="">On Fri, Sep 15, 2017 at 5:31 AM, Stefan Fuchs <a class="moz-txt-link-rfc2396E" href="mailto:sfuchs@gmx.de" moz-do-not-send="true"><sfuchs@gmx.de></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Sorry for the maybe stupid questions: This does already solve the issue with
the spike I reported, isn't it?
</pre>
</blockquote>
<pre wrap="">Maybe. I'm not convinced it didn't exist before, though, although
maybe hidden. It definitely existed as far as the o2pressure was
concerned, since that wasn't cleared before either.
</pre>
</blockquote>
I can still create one interesting situation where I finally will
have the issue (all related files are attached):<br>
- I plan a new dive of the specific kind (deco gas used as first
gas and then used later again) with the planner and save it to a
new XML file<br>
--> Everything ok, no vertical line in graph, in XML at time
of gas change 43:35 there is no pressure value. This is as Linus
said it should be.<br>
- I close Subsurface, restart, open XML<br>
--> Everything ok, no vertical line in graph<br>
- Replan dive in planner<br>
--> Vertical line at ~43min appears and if I now save this
and look in the XML a pressure value was added at 43:35 which is
incorrect.<br>
<br>
The question is now: Why does the planner (or whatever) does the
thing correctly when creating the dive but then does a mistake
when replanning the same dive?<br>
</blockquote>
Could you please have a quick look at this:<br>
<a class="moz-txt-link-freetext" href="https://github.com/Subsurface-divelog/subsurface/pull/628">https://github.com/Subsurface-divelog/subsurface/pull/628</a><br>
<br>
I think I identified the position in the code where the planner
writes this ambiguous and unnecessary pressure information which
confuses the plot code.<br>
And I even think that we can simply fix this w/o side effects. At
least tests on my side show positive results.<br>
<br>
What do you think?<br>
<br>
Best regards<br>
Stefan<br>
<br>
<br>
<div class="moz-signature">-- <br>
<meta http-equiv="CONTENT-TYPE" content="text/html; charset=utf-8">
<title></title>
<meta name="GENERATOR" content="OpenOffice.org 3.3 (Win32)">
<meta name="CREATED" content="0;0">
<meta name="CHANGEDBY" content="Stefan Fuchs">
<meta name="CHANGED" content="20120503;23115492">
<style type="text/css">
<!--
P { color: #000000 }
-->
</style>
<p>Stefan Fuchs<br>
E-Mail: <a href="mailto:sfuchs@gmx.de">sfuchs@gmx.de</a></p>
</div>
</body>
</html>