<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hello Rick,<br>
</p>
Am 20.10.2017 um 04:04 schrieb Rick Walsh:<br>
<blockquote type="cite"
cite="mid:CAF+v9Jsq3JR7ELnjX4xSZbmxz6Vok5dCbhRKrM8cdfVtX6gKrA@mail.gmail.com">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr"><br>
<div class="gmail_extra">Based on a little bit of
testing I'm doing while I can't do my actual work, the
good news appears to be:<br>
- the issue only relates to the displayed ceiling in
the planner, not to the dive plan itself.<br>
- The tests still pass.<br>
- once the plan is saved, the dive profile is
displayed with a reasonable ceiling, consistent with
the dive plan<br>
<br>
</div>
[...]<br>
<div class="gmail_extra">The following change to
core/profile.c:1015 might be a fix based on the second
option, but I don't have a build environment to test.<br>
Change:<br>
/* If using VPM-B outside the planner,
take first_ceiling_pressure as the deepest ceiling */<br>
if (decoMode() == VPMB) {<br>
if (current_ceiling >
first_ceiling) {<br>
time_deep_ceiling = t1;<br>
<br>
<br>
To:<br>
/* If using VPM-B outside the planner,
take first_ceiling_pressure as the deepest ceiling */<br>
if (decoMode() == VPMB) {<br>
if (current_ceiling >=
first_ceiling || entry->depth >=
entry[-1].depth) {<br>
time_deep_ceiling = t1;<br>
<br>
</div>
</div>
</blockquote>
<div>[...]
<table style="margin:0px" cellspacing="2" cellpadding="0"
border="0">
<thead><tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</thead><tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>
<br>
Try:<br>
/* If using VPM-B outside the planner,
take first_ceiling_pressure as the deepest ceiling */<br>
if (decoMode() == VPMB) {<br>
if (current_ceiling >=
first_ceiling || (time_deep_ceiling = t0 &&
entry->depth >= entry[-1].depth)) {<br>
time_deep_ceiling = t1;<br>
<br>
</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div class="gmail_extra">Could someone with a build
environment please test?<br>
</div>
<br>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
Tested both variants but unfortunately none of both gave a
satisfying result.<br>
In both cases the displayed ceiling neither does fit some of my real
dives nor does fit together with the planner waypoints any longer.
Both variants show similar results, so I attach screenshots from the
first variant only.<br>
For the real dive shown below this is way to much ceiling.<br>
<br>
<br>
<img src="cid:part1.7D6F6A5A.E9CC4C71@gmx.de" alt=""><br>
<br>
<img src="cid:part2.AE37A83D.5E04B4D3@gmx.de" alt=""><br>
<br>
<div class="moz-signature">-- <br>
<meta http-equiv="CONTENT-TYPE" content="text/html; charset=utf-8">
<title></title>
<meta name="GENERATOR" content="OpenOffice.org 3.3 (Win32)">
<meta name="CREATED" content="0;0">
<meta name="CHANGEDBY" content="Stefan Fuchs">
<meta name="CHANGED" content="20120503;23115492">
<style type="text/css">
<!--
P { color: #000000 }
-->
</style>
<p>Stefan Fuchs<br>
E-Mail: <a href="mailto:sfuchs@gmx.de">sfuchs@gmx.de</a></p>
</div>
</body>
</html>