<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi All,<br>
<br>
<div class="moz-cite-prefix">Am 20.10.2017 um 16:11 schrieb
Guillaume Gardet:<br>
</div>
<blockquote type="cite"
cite="mid:3e18d085-77eb-d60e-987c-e327bad469bc@free.fr"><br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">That's ugly. I found s.th. similar
this morning also when deleting a cylinder but only in the
merged dive I played with.
<br>
Could come from my changes. I found already one bug and
fixed it (see PRs) but that was not all - crash still
there.
<br>
</blockquote>
<br>
Start Subsurface
<br>
<br>
Select file -> New logbook
<br>
<br>
Select Log -> Plan dive
<br>
<br>
Mine starts with a single D12 AIR twinset being defined and
a 20 min dive at 15m.
<br>
<br>
Add an AL80 cylinder with EAN50
<br>
<br>
In nth Dive points table change the dive to 60 minutes at
20m (results in awful profile)
<br>
<br>
Delete EAN50 cylinder
<br>
<br>
Crash
<br>
<br>
</blockquote>
Odd. Usually I'm the one seeing all the crashes with my MXE
Windows build. But not this one.
<br>
Any new findings?
<br>
Can you provide a screenshot of the full planner window with
the setup?
<br>
<br>
Meanwhile I will try another build flavor and then also Linux.
<br>
</blockquote>
Ok, I have it in front of me now:
<br>
Seems to be nothing were we or I did really change s.th. during
the last days. But for sure what I did is that I implemented a
few more triggers for updates between the cylinder table and
everything else in the planner. That may have revealed an issue.
<br>
<br>
BT attached below.
<br>
<br>
From my limited experience:
<br>
Is this s.th. coming from a race condition?
<br>
We do check in planner .c update_cylinder_pressure for "if
(!cyl)", this doesn't "fail" and then we crash a few lines later
doing "cyl->gas_used.mliter += gas_used.mliter;"
<br>
<br>
</blockquote>
</blockquote>
<br>
Could you please try:<br>
<a class="moz-txt-link-freetext" href="https://github.com/Subsurface-divelog/subsurface/pull/704">https://github.com/Subsurface-divelog/subsurface/pull/704</a><br>
<br>
<br>
<div class="moz-signature">-- <br>
<meta http-equiv="CONTENT-TYPE" content="text/html; charset=utf-8">
<title></title>
<meta name="GENERATOR" content="OpenOffice.org 3.3 (Win32)">
<meta name="CREATED" content="0;0">
<meta name="CHANGEDBY" content="Stefan Fuchs">
<meta name="CHANGED" content="20120503;23115492">
<style type="text/css">
<!--
P { color: #000000 }
-->
</style>
<p>Stefan Fuchs<br>
E-Mail: <a href="mailto:sfuchs@gmx.de">sfuchs@gmx.de</a></p>
</div>
</body>
</html>