<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Linus has already responded, but this one is important to me, so I’ll chime in as well…<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 17, 2017, at 11:22 AM, Stefan Fuchs <<a href="mailto:sfuchs@gmx.de" class="">sfuchs@gmx.de</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); float: none; display: inline !important;" class="">Am 17.11.2017 um 03:05 schrieb Linus Torvalds:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);" class=""><blockquote type="cite" cite="mid:CA+55aFy5mpRRCvF=9yiS8TfouCszLg22+svKd9YgEJ5=6okU-g@mail.gmail.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);" class=""><pre wrap="" class="">And I think it merits some cleanup first.
Something like the attached three patches?
NOTE! Untested. And it's not smaller than your patch. I just think
it's a bit more explicit about what it does, and thus maybe clearer.
But I don't <span class="moz-txt-underscore"><span class="moz-txt-tag">_</span>hate<span class="moz-txt-tag">_</span></span> your patch either.</pre></blockquote><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); float: none; display: inline !important;" class="">Linus, don't worry! ;-) I'm absolutely happy with the situation.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); float: none; display: inline !important;" class="">BTW: I tested your patches with good results, answered on Github and your PR is in master now. I also sent a PR to mention this in the release notes because I had some other changes there.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);" class=""></div></blockquote><div><br class=""></div>That, BTW (making sure things are documented) is extremely helpful; and anyone can</div><div>do that, no programming genius required.</div><div><br class=""><blockquote type="cite" class=""><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); float: none; display: inline !important;" class="">It will still happen regularly that I will be the one who only can either "complain" about<span class="Apple-converted-space"> </span></span><a href="http://s.th/" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);" class="">s.th</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); float: none; display: inline !important;" class="">. not working or best case suggest a concept but someone else has to do the "nice" code. I'm still far away from being a good SW developer.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);" class=""></div></blockquote></div><br class=""></div><div class="">If the worst that someone can say about your code is that “Linus was able to do the</div><div class="">same thing in a patch that was nicer”, then you are an incredibly lucky and gifted</div><div class="">developer.</div><div class=""><br class=""></div><div class="">Seriously - what matters to me, what matters to us in this project is that we make</div><div class="">it better. So people like you are worth your weight in gold. Not only do you point</div><div class="">out things that don’t work, you test things, you test solutions, you are responsive,</div><div class="">you write code. That’s amazing. And if sometimes we end up taking a different</div><div class="">patch set then that’s perfectly ok and we all should be happy.</div><div class=""><br class=""></div><div class="">And also, we have quite a few people here who point out things that don’t work</div><div class="">and who test and re-test and who maybe draw better UI layouts (thinking of Davide)</div><div class="">but who don’t write a single line of code.</div><div class=""><br class=""></div><div class="">Those, too, are really important to a project like Subsurface. Because there’s no</div><div class="">way the developers can test all platforms, all dive computers, all types of divers.</div><div class="">For example - very few of the active developers use Subsurface to plan dives.</div><div class="">So it’s the users who do who provide all this important feedback.</div><div class=""><br class=""></div><div class="">And then there are the translators, the people writing the documentation. Etc. Etc.</div><div class=""><br class=""></div><div class="">It takes a lot of people who contribute to make this the project that it is. And everyone’s</div><div class="">contributions are welcome.</div><div class=""><br class=""></div><div class="">Specifically: Stefan, I really appreciate the tremendous contributions you have made </div><div class="">to Subsurface this past year. Thank you.</div><div class=""><br class=""></div><div class="">/D</div></body></html>