<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 18/11/2017 00:01, Lubomir I. Ivanov
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:Subsurface-divelog%2Fsubsurface%2Fpull%2F828%2Freview%2F77567878@github.com">
<p><b>@neolit123</b> requested changes on this pull request.</p>
<p><a href="https://github.com/willemferguson"
class="user-mention">@willemferguson</a></p>
<p>hi, Willem. i've made a more detailed review for this commit.
it needs work, before we can accept it in. so, please, comment
on my comments if you'd like.</p>
<p>most importantly, please do not change the bundled "One
Dive.html<code>file and instead commit a new one - e.g.</code>One
Dive .html`.</p>
<p>you might have to learn how to <code>git rebase</code>.</p>
</blockquote>
Lubomir,<br>
<br>
I think I will just send a patch that does not include the automatic
text sizing in the notes text field. This will remove the hacked
code. I will work with that separately and if I can get a more
elegant solution submit that as a separate PR.<br>
<br>
I agree that we should keep the old version.<br>
<br>
Does this sound acceptable?<br>
<br>
Kind regards,<br>
willem<br>
<br>
</body>
</html>
<br>
<div style="font-family:Arial,Helvetica,sans-serif"><span style="font-size:10.0pt;line-height:105%;font-family:"Segoe UI",sans-serif">This message and attachments are subject to a disclaimer.<br>
Please refer to <a href="http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf" target="_blank">http://upnet.up.ac.za/<wbr>services/it/documentation/<wbr>docs/004167.pdf</a> </span><span style="font-size:10pt;line-height:105%;font-family:Tahoma,sans-serif">for
full details.</span></div>