<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 19/11/2017 19:22, Lubomir I. Ivanov
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:Subsurface-divelog%2Fsubsurface%2Fpull%2F839%2Fc345533625@github.com">
<p><a href="https://github.com/willemferguson"
class="user-mention" moz-do-not-send="true">@willemferguson</a>
<a href="https://github.com/dirkhh" class="user-mention"
moz-do-not-send="true">@dirkhh</a></p>
<p>we've discussed that we should not touch the old template which
also implies renaming it.<br>
the solution is to create a new template with a different name.</p>
<p>questions:</p>
<ul>
<li>how is this template an improvement over the current one
dive template?</li>
<li>how should we name it? using <code>Old</code> / <code>New</code>
is kind of bad and has no meaning.</li>
</ul>
<p
style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
You are receiving this because you were mentioned.<br>
Reply to this email directly, <a
href="https://github.com/Subsurface-divelog/subsurface/pull/839#issuecomment-345533625"
moz-do-not-send="true">view it on GitHub</a>, or <a
href="https://github.com/notifications/unsubscribe-auth/AE1-sj6Ap2_BhSbBc07SvgWQoIRjtk7wks5s4GO-gaJpZM4QjaYb"
moz-do-not-send="true">mute the thread</a>.<img alt=""
src="https://github.com/notifications/beacon/AE1-svZu9gGhrhkeKjIrWsvI2OsipMFZks5s4GO-gaJpZM4QjaYb.gif"
moz-do-not-send="true" height="1" width="1"></p>
<div itemscope="" itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope=""
itemtype="http://schema.org/ViewAction">
<link itemprop="url"
href="https://github.com/Subsurface-divelog/subsurface/pull/839#issuecomment-345533625">
<meta itemprop="name" content="View Pull Request">
</div>
<meta itemprop="description" content="View this Pull Request on
GitHub">
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Subsurface-divelog/subsurface","title":"Subsurface-divelog/subsurface","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/Subsurface-divelog/subsurface"}},"updates":{"snippets":[{"icon":"PERSON","message":"@neolit123 in #839: @willemferguson @dirkhh \r\n\r\nwe've discussed that we should not touch the old template which also implies renaming it.\r\nthe solution is to create a new template with a different name.\r\n\r\nquestions:\r\n- how is this template an improvement over the current one dive template?\r\n- how should we name it? using `Old` / `New` is kind of bad and has no meaning.\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/Subsurface-divelog/subsurface/pull/839#issuecomment-345533625"}}}</script>
</blockquote>
<p>The agreement was that the original template should be kept. It
was not that that it should be kept with the same template name.<br>
</p>
<p>Look at the attached image, comparing the two templates (new
template on the left, old template on the right).</p>
<p>1) The old layout cannot gracefully handle table entries with
more than one line, resulting in a ragged bottom edge to the
table. The new template does not have the problem. Because of this
the old template is inefficient and wastes space on the page.<br>
</p>
<p>2) The new template gives almost 20% greater vertical increase in
image size of the profile, using similar or or even less total
vertical page space than the old template. The old template is
wasteful of vertical space in almost all elements of the layout if
you start looking carefully at it. Look at the heights of the rows
in the table. Look at white space between sections of the page.<br>
</p>
<p>3) The old template is inefficient with profile at the top. The
*important* information is in fact not the profile but the dive
information below the profile in the old template. I think I
understand why the table is underneath in the old template,
because of problems with the alignment of the table containing the
dive data. From a layout point of view the important information
should be at the top. This is an important layout problem. The new
template puts the important information at the top.</p>
<p>4) Ridiculous information like air temperature, which a dive
computer cannot measure accurately (believe me, I am an
environmental scientist that routinely works with weather
stations) is replaced with more meaningful information (in this
case cylinder and gas information.)<br>
</p>
<p>Any one of the four above criteria on its own is sufficient
grounds for making the new template the default. Are you sure you
wish to keep the old template as the default? Do you have a
compelling reason for keeping the old template at all?<br>
</p>
<p>My proposal is to rename the old template as in the patch.</p>
<p>Kind regards,</p>
<p>willem</p>
<p><br>
</p>
</body>
</html>
<br>
<div style="font-family:Arial,Helvetica,sans-serif"><span style="font-size:10.0pt;line-height:105%;font-family:"Segoe UI",sans-serif">This message and attachments are subject to a disclaimer.<br>
Please refer to <a href="http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf" target="_blank">http://upnet.up.ac.za/<wbr>services/it/documentation/<wbr>docs/004167.pdf</a> </span><span style="font-size:10pt;line-height:105%;font-family:Tahoma,sans-serif">for
full details.</span></div>