<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">So much fun to wake up to such good news.<div class="">Thank you, Murillo!</div><div class=""><br class=""></div><div class="">I glanced through the diff and (like Miika) am not quite sure why you changed things to QString (if this is needed, could this be a separate commit?)</div><div class="">And of course the question is "why isn't the call to connectionListMode.addAddress()" not needed? And likewise "why aren't we calling saveBtDeviceInfo(...) on the other platforms".</div><div class=""><br class=""></div><div class="">I'd love to see a pull request - this makes it easy to get it tested on all of our platforms.</div><div class=""><br class=""></div><div class="">I don't think you've submitted code to Subsurface before - it's fairly straight forward, CONTRIBUTING.md contains the basics and of course feel free to ask if you need help :-)</div><div class=""><br class=""></div><div class="">/D</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 1, 2017, at 1:48 AM, Murillo Bernardes <<a href="mailto:mfbernardes@gmail.com" class="">mfbernardes@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<title class=""></title>
<div class="">
<div name="messageBodySection" class="">Yeah, it ended up being simple. I just need to make sure I don’t break android and desktop before sending an actual patch.</div>
<div name="messageSignatureSection" class=""><br class="">
—<br class="">
Murillo</div>
<div name="messageReplySection" class=""><br class="">
On 1 Dec 2017 17:38 +0800, Miika Turkia <<a href="mailto:miika.turkia@gmail.com" class="">miika.turkia@gmail.com</a>>, wrote:<br class="">
<blockquote type="cite" class="">
<div dir="ltr" class="">
<div class="gmail_extra">
<div class="gmail_quote">Cool. Looks almost too simple, especially when ignoring the changes from char * to QString :D</div>
<div class="gmail_quote"><br class=""></div>
<div class="gmail_quote">miika<br class=""></div>
<div class="gmail_quote"><br class=""></div>
<div class="gmail_quote">On Fri, Dec 1, 2017 at 11:08 AM, Murillo Bernardes <span dir="ltr" class=""><<a href="mailto:mfbernardes@gmail.com" target="_blank" class="">mfbernardes@gmail.com</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr" class="">For now this is just a hack, not final code yet, but *works* fine with my Perdix AI. I'm able to connect and download dives.
<div class="">
<div class=""><br class=""></div>
<div class="">Actually populating BtDeviceInfo with devices discovered, it can be used successfully later.</div>
<div class=""><br class=""></div>
<div class="">I was able to successfully connect, download dives, cancel download, restart.</div>
<div class="">
<div class="gmail_extra"><br class=""></div>
<div class="gmail_extra"><img width="1242" height="2208" class="" apple-inline="yes" id="B605C247-24AE-48D8-B5A3-1E5425357E0F" apple-width="yes" apple-height="yes" src="cid:ii_janor4n81_16011548511de126"><br class="">
<br class=""></div>
<div class="gmail_extra"><br class=""></div>
<div class="gmail_extra">--<br clear="all" class="">
<div class="">
<div class="m_4495115323119208280gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr" class="">
<div class="">Murillo</div>
</div>
</div>
</div>
<div class="">
<div class="h5"><br class="">
<div class="gmail_quote">On Fri, Dec 1, 2017 at 3:35 PM, Murillo Bernardes <span dir="ltr" class=""><<a href="mailto:mfbernardes@gmail.com" target="_blank" class="">mfbernardes@gmail.com</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr" class="">
<div class="">
<div class="m_4495115323119208280h5">
<div class="gmail_extra">
<div class="">
<div class="m_4495115323119208280m_-2614311348375460975gmail_signature">
<div dir="ltr" class=""><br class=""></div>
</div>
</div>
<br class="">
<div class="gmail_quote">On Fri, Dec 1, 2017 at 2:56 PM, Dirk Hohndel <span dir="ltr" class=""><<a href="mailto:dirk@hohndel.org" target="_blank" class="">dirk@hohndel.org</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div style="word-wrap:break-word" class=""><br class="">
<div class="">
<div class="m_4495115323119208280m_-2614311348375460975gmail-">
<blockquote type="cite" class="">
<div class="">On Nov 30, 2017, at 8:53 PM, Murillo Bernardes <<a href="mailto:mfbernardes@gmail.com" target="_blank" class="">mfbernardes@gmail.com</a>> wrote:</div>
<div class="">
<div dir="ltr" class="">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div dir="ltr" class="">Could this mean that the device cannot be paired with iPhone using the iOS settings? Of course, I have already paired the DC with my Android tablet and that might also affect my hardship... How did others pair their BLE Perdix with iPhone/iPad?</div>
</blockquote>
<div class=""><br class=""></div>
<div class="">With Perdix AI (BLE) is up to the application to discover and connect to the dive computer. While it is connected it will show under iOS settings, but as soon as the application disconnects or closes it will be gone. Nothing wrong there.</div>
</div>
</div>
</div>
</div>
</blockquote>
<div class=""><br class=""></div>
</div>
I'll have to figure out if I can scan for the device, or if I need to hard code UUIDs or something.</div>
<div class="">Nothing is ever easy :-(</div>
<div class="">
<div class="m_4495115323119208280m_-2614311348375460975gmail-"><br class="">
<blockquote type="cite" class="">
<div class="">
<div dir="ltr" class="">
<div class="gmail_extra">
<div class="gmail_quote">
<div class="">Subsurface-mobile on iOS is not working properly with BLE yet, so it doesn't connect.</div>
</div>
</div>
</div>
</div>
</blockquote>
<div class=""><br class=""></div>
</div>
Yup</div>
<div class=""><br class=""></div>
<div class="">I'll work on it. I'm still hoping that other developers will start participating in the iOS development.</div>
<div class="">Because you all know my time is limited and this is not the most important thing to spend it on in the larger scope of things (by FAR our smallest user group)</div>
<div class="m_4495115323119208280m_-2614311348375460975gmail-HOEnZb"><font color="#888888" class=""></font>
<div class=""><font color="#888888" class=""><br class=""></font></div>
<div class=""><font color="#888888" class="">/D</font></div>
<font color="#888888" class=""><br class=""></font></div>
</div>
</blockquote>
</div>
<br class=""></div>
</div>
</div>
<div class="gmail_extra">I'm taking a look. Got my dev environment setup. Here is somethings I found.</div>
<div class="gmail_extra"><br class=""></div>
<div class="gmail_extra">I can get my Perdix AI to show in the list, but it fails to connect.</div>
<div class="gmail_extra"><br class=""></div>
<div class="gmail_extra">First thing on DownloadFromDiveComputer.qm<wbr class="">l:161 it contains a regex to match an address. On iOS it is actually the uuid, so it passes as a serial.</div>
<div class="gmail_extra"><br class=""></div>
<div class="gmail_extra">I changed the regex to:</div>
<div class="gmail_extra"><br class=""></div>
<div class="gmail_extra">var btAddr = /(LE:)?\{?[0-9a-fA-F]{8}-[0-9a<wbr class="">-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a<wbr class="">-fA-F]{4}-[0-9a-fA-F]{12}\} .*?/;<br class=""></div>
<div class="gmail_extra"><br class=""></div>
<div class="gmail_extra">then it's set as bluetooth and actually tries to open via qt_ble_open. </div>
<div class="gmail_extra"><br class=""></div>
<div class="gmail_extra">On qt-ble.cpp:300 getBtDeviceInfo does not return a populated object. I couldn't see btDeviceInfo (btdiscovery.cpp) ever being populated actually, so there is nothing to return.</div>
<div class="gmail_extra"><br class=""></div>
<div class="gmail_extra">--</div>
<div class="gmail_extra">Murillo</div>
</div>
</blockquote>
</div>
<br class=""></div>
</div>
</div>
</div>
</div>
</div>
<br class="">
______________________________<wbr class="">_________________<br class="">
subsurface mailing list<br class="">
<a href="mailto:subsurface@subsurface-divelog.org" class="">subsurface@subsurface-divelog.<wbr class="">org</a><br class="">
<a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" rel="noreferrer" target="_blank" class="">http://lists.subsurface-<wbr class="">divelog.org/cgi-bin/mailman/<wbr class="">listinfo/subsurface</a><br class="">
<br class=""></blockquote>
</div>
<br class=""></div>
</div>
</blockquote>
</div>
</div>
</div></blockquote></div><br class=""></div></body></html>