<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 1, 2017, at 7:50 AM, Murillo Bernardes <<a href="mailto:mfbernardes@gmail.com" class="">mfbernardes@gmail.com</a>> wrote:</div><div class=""><div dir="ltr" class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Dec 1, 2017 at 11:18 PM, Dirk Hohndel <span dir="ltr" class=""><<a href="mailto:dirk@hohndel.org" target="_blank" class="">dirk@hohndel.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word" class="">So much fun to wake up to such good news.<div class="">Thank you, Murillo!</div><div class=""><br class=""></div><div class="">I glanced through the diff and (like Miika) am not quite sure why you changed things to QString (if this is needed, could this be a separate commit?)</div></div></blockquote><div class=""><br class=""></div><div class="">Change to QStrings is not really necessary, just made it quicker for me to test what I really wanted to test.</div></div></div></div></div></blockquote><div><br class=""></div>OK</div><div> <br class=""><blockquote type="cite" class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word" class=""><div class="">And of course the question is "why isn't the call to connectionListMode.addAddress(<wbr class="">)" not needed? </div></div></blockquote><div class=""><br class=""></div><div class=""><div class="">It is needed, still there for newDC. This just removed from the list things we "know" (maybe not for a fact) are not DC. I haven't understood yet all the code involved, so I might be missing something.</div><div class=""><br class=""></div><div class="">Just to make BLE work this change is not really needed, sure.</div></div></div></div></div></blockquote><div><br class=""></div><div>I'm not sure I understand your answer. But then I should stare at the code in context some more.</div><br class=""><blockquote type="cite" class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word" class=""><div class="">And likewise "why aren't we calling saveBtDeviceInfo(...) on the other platforms".</div></div></blockquote><div class=""><br class=""></div><div class="">I only found references to getBtDeviceInfo on a code specific for Mac and iOS (qt-ble.cpp:300). Not sure how this works on Mac since it is never populated.</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">It's not clear why for each device discovered, instead of just storing the DeviceInfo we instead use this info to create multiple other structures (like <span style="color:rgb(9,46,100)" class="">serviceUuids, btDCs) and later try to reconstruct whatever is needed.</span></div></div></div></div></blockquote><div><br class=""></div><div>I think it is fair to say that this code went through a lot of iterations between the initial ideas and what ended up working across all of the platforms. It may be a good idea to look into cleaning things up and simplifying the data structures, once we have it all working.</div><br class=""><blockquote type="cite" class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word" class=""><div class=""></div><div class="">I'd love to see a pull request - this makes it easy to get it tested on all of our platforms. </div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word" class=""><div class=""><br class=""></div><div class="">I don't think you've submitted code to Subsurface before - it's fairly straight forward, CONTRIBUTING.md contains the basics and of course feel free to ask if you need help :-)</div><span class="gmail-HOEnZb"><font color="#888888" class=""><div class=""><br class=""></div></font></span></div></blockquote><div class=""><br class=""></div><div class=""><div class="">I'm working on a proper patch and will create a PR, with signed-off patches and all.</div></div></div></div></div></blockquote><br class=""></div><div>Thank you. Much appreciated</div><div><br class=""></div><div>/D</div><br class=""></body></html>