<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hello Willem,<br>
</p>
Am 04.01.2018 um 07:13 schrieb Willem Ferguson:<br>
<blockquote type="cite"
cite="mid:6a24e883-26c2-6327-293c-5062b0caaee9@zoology.up.ac.za"><br>
<blockquote type="cite">Can you do a Github PR for this? For me
it's much easier to discuss it there and also to pull and test
it :-)
<br>
<br>
</blockquote>
Done. The title of the PR is a bit obscure, not intended.
<br>
Kind regards,
<br>
willem
<br>
</blockquote>
Honestly the whole PR looks a little bit "obscure" or in other words
- there went s.th. wrong ;-)<br>
<br>
Maybe the way you did the PR (file upload?!) is not the best one.
But even if it works there are two other mistakes beside the PR
title:<br>
- The file has to go in /core/plannernots.c<br>
- The commit title is also wrong<br>
<br>
Maybe better to do the PR in the way of pushing the change to your
own GitHub repo and then do the PR from there.<br>
I'm also no real pro but my flow usually looks like:<br>
- Change is available in my local git repo in a branch I call
"mystable" including 1-n commits<br>
- Local branch master is up to date<br>
- git checkout -b feature_whatever<br>
- git rebase -i master<br>
Remove everything which is NOT part of the change<br>
- git push <a class="moz-txt-link-freetext" href="https://github.com/sfuchs79/subsurface.git">https://github.com/sfuchs79/subsurface.git</a>
feature_whatever<br>
- Then do the PR on GitHub<br>
<br>
Best regards<br>
Stefan<br>
<br>
<div class="moz-signature">-- <br>
<meta http-equiv="CONTENT-TYPE" content="text/html; charset=utf-8">
<title></title>
<meta name="GENERATOR" content="OpenOffice.org 3.3 (Win32)">
<meta name="CREATED" content="0;0">
<meta name="CHANGEDBY" content="Stefan Fuchs">
<meta name="CHANGED" content="20120503;23115492">
<style type="text/css">
<!--
P { color: #000000 }
-->
</style>
<p>Stefan Fuchs<br>
E-Mail: <a href="mailto:sfuchs@gmx.de">sfuchs@gmx.de</a></p>
</div>
</body>
</html>