<div dir="ltr"><div>Hello Thiago,</div><div><br></div>In order to not mix the two topics in the same change, I decided to keep the conversion to QString as it was in the original code, see:<div><a href="https://github.com/Subsurface-divelog/subsurface/blob/12dc1889c704c6af9125d3ef3f0d2a1c1fe603f7/desktop-widgets/tab-widgets/maintab.cpp#L574">https://github.com/Subsurface-divelog/subsurface/blob/12dc1889c704c6af9125d3ef3f0d2a1c1fe603f7/desktop-widgets/tab-widgets/maintab.cpp#L574</a></div><div><a href="https://github.com/Subsurface-divelog/subsurface/blob/12dc1889c704c6af9125d3ef3f0d2a1c1fe603f7/desktop-widgets/tab-widgets/maintab.cpp#L1529">https://github.com/Subsurface-divelog/subsurface/blob/12dc1889c704c6af9125d3ef3f0d2a1c1fe603f7/desktop-widgets/tab-widgets/maintab.cpp#L1529</a></div><div><a href="https://github.com/Subsurface-divelog/subsurface/blob/12dc1889c704c6af9125d3ef3f0d2a1c1fe603f7/qt-models/divetripmodel.cpp#L430">https://github.com/Subsurface-divelog/subsurface/blob/12dc1889c704c6af9125d3ef3f0d2a1c1fe603f7/qt-models/divetripmodel.cpp#L430</a></div><div>I can now prepare a follow up change that would deal with the issue you have raised, the advantage is that now it must be fixed in a single place :)</div><div><br></div><div>Thanks for the feedback,</div><div><br></div><div>Jeremie</div></div><div class="gmail_extra"><br><div class="gmail_quote">2018-04-05 5:27 GMT+02:00 Thiago Macieira <span dir="ltr"><<a href="mailto:thiago@macieira.org" target="_blank">thiago@macieira.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wednesday, 4 April 2018 02:55:22 PDT Berthold Stoeger wrote:<br>
>   char *s = taglist_get_tagstring(...);<br>
>   QString tags(s);<br>
>   free(s);<br>
<br>
</span>One minor note: this decodes the string as UTF-8. If your string is Latin1 or<br>
plain US-ASCII, you should use QString::fromLatin1 or QLatin1String (same<br>
thing in this context).<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Thiago Macieira - thiago (AT) <a href="http://macieira.info" rel="noreferrer" target="_blank">macieira.info</a> - thiago (AT) <a href="http://kde.org" rel="noreferrer" target="_blank">kde.org</a><br>
   Software Architect - Intel Open Source Technology Center<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
subsurface mailing list<br>
<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.<wbr>org</a><br>
<a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" rel="noreferrer" target="_blank">http://lists.subsurface-<wbr>divelog.org/cgi-bin/mailman/<wbr>listinfo/subsurface</a><br>
</font></span></blockquote></div><br></div>