<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 9, 2018 at 12:41 PM, Jérémie Guichard <span dir="ltr"><<a href="mailto:djeBrest@gmail.com" target="_blank">djeBrest@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi everybody,</div><div><br></div><div>To cope with this I've prepared a change introducing a new CONVENTIONS.md file that is meant to collect such information: <a href="https://github.com/Subsurface-divelog/subsurface/pull/1196" target="_blank">https://github.<wbr>com/Subsurface-divelog/<wbr>subsurface/pull/1196</a> Any feedback is welcome. Since it is the one convention I learned during a recent pull request I proposed, I started with documenting the use of membuffer for string manipulations...</div></div></blockquote><div><br></div><div>What is the distinction between the existing CodingStyle and the proposed CONVENTIONS.md? IMO, what you currently have there could have easily been included in the CodingStyle. Having all the essential information in single place sounds better for newcomers.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div>Then if/when the currently discussed pull request would be approved it would be nice to reflect these changes in the corresponding page on <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><a href="https://subsurface-divelog.org" target="_blank">https://subsurface-divelog.<wbr>org</a>. The question is: Was this page manually edited in Subsurface-website repository or was it actually generated from markdown? If so, is the script available somewhere?</span></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><br></span></div></div></blockquote><div>IIRC these are edited directly.<br><br></div><div>miika<br></div></div><br></div></div>