<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 9, 2018, at 3:26 AM, Miika Turkia <<a href="mailto:miika.turkia@gmail.com" class="">miika.turkia@gmail.com</a>> wrote:</div><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><div class=""><br class=""></div><div class="">To cope with this I've prepared a change introducing a new CONVENTIONS.md file that is meant to collect such information: <a href="https://github.com/Subsurface-divelog/subsurface/pull/1196" target="_blank" class="">https://github.<wbr class="">com/Subsurface-divelog/<wbr class="">subsurface/pull/1196</a> Any feedback is welcome. Since it is the one convention I learned during a recent pull request I proposed, I started with documenting the use of membuffer for string manipulations...</div></div></blockquote><div class=""><br class=""></div><div class="">What is the distinction between the existing CodingStyle and the proposed CONVENTIONS.md? IMO, what you currently have there could have easily been included in the CodingStyle. Having all the essential information in single place sounds better for newcomers.<br class=""></div></div></div></div></div></blockquote><div><br class=""></div><div>I think I'll have to agree with Miika on this one. Fewer places to read through make it easier for people to find what they are looking for.</div><div>One could of course argue that using membuffer and other such conventions technically aren't coding style, but I think with a slightly more liberal interpretation of that term... simply add a section called "Conventions" to the CodingStyle document and I think we will all be happier :-)</div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><div class="">Then if/when the currently discussed pull request would be approved it would be nice to reflect these changes in the corresponding page on <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline" class=""><a href="https://subsurface-divelog.org/" target="_blank" class="">https://subsurface-divelog.<wbr class="">org</a>. The question is: Was this page manually edited in Subsurface-website repository or was it actually generated from markdown? If so, is the script available somewhere?</span></div><div class=""><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline" class=""><br class=""></span></div></div></blockquote><div class="">IIRC these are edited directly.<br class=""></div></div></div></div></blockquote></div><br class=""><div class="">The website is run on a WordPress instance that is synced (in a somewhat fragile manner) with a GitHub repo. So the sources for the page in question should be here:</div><div class=""><br class=""></div><div class=""><a href="https://github.com/Subsurface-divelog/Subsurface-website/blob/master/_pages/contributing.en" class="">https://github.com/Subsurface-divelog/Subsurface-website/blob/master/_pages/contributing.en</a></div><div class=""><br class=""></div><div class="">The translations of the website are unfortunately not as well maintained as one might hope (this is all volunteer work and it's tedious work...), but you can see the translations in the GitHub repo as well.</div><div class=""><br class=""></div><div class="">/D</div></body></html>