<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<div class="moz-forward-container"><br>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div class="moz-cite-prefix">On 18/04/2018 15:42, Robert C.
Helling wrote:<br>
</div>
<blockquote type="cite"
cite="mid:Subsurface-divelog%2Fsubsurface%2Fpull%2F1166%2Fc382390636@github.com">
<p>Sorry, I missed this.</p>
<p>From a coding perspective: This looks good to me.</p>
<p>Could you explain, in which situation this "OC equivalent"
becomes relevant, why would one look at this line?</p>
<p>Further, why don't you directly base this onto your branch
which makes the divemode time depenent (which is in my opinion
close to merging)?</p>
<p
style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
You are receiving this because you authored the thread.<br>
Reply to this email directly, <a
href="https://github.com/Subsurface-divelog/subsurface/pull/1166#issuecomment-382390636"
moz-do-not-send="true">view it on GitHub</a>, or <a
href="https://github.com/notifications/unsubscribe-auth/AE1-sj4yiTVimcbksutR6VAMENv0ety9ks5tp0LSgaJpZM4Sqq3n"
moz-do-not-send="true">mute the thread</a>.<img
src="https://github.com/notifications/beacon/AE1-spBxYtuGEfyluKs6sp27beyrx-M-ks5tp0LSgaJpZM4Sqq3n.gif"
alt="" moz-do-not-send="true" width="1" height="1"></p>
<div itemscope="" itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope=""
itemtype="http://schema.org/ViewAction">
<link itemprop="url"
href="https://github.com/Subsurface-divelog/subsurface/pull/1166#issuecomment-382390636">
<meta itemprop="name" content="View Pull Request">
</div>
<meta itemprop="description" content="View this Pull Request
on GitHub">
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Subsurface-divelog/subsurface","title":"Subsurface-divelog/subsurface","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/Subsurface-divelog/subsurface"}},"updates":{"snippets":[{"icon":"PERSON","message":"@atdotde in #1166: Sorry, I missed this.\r\n\r\nFrom a coding perspective: This looks good to me.\r\n\r\nCould you explain, in which situation this \"OC equivalent\" becomes relevant, why would one look at this line?\r\n\r\nFurther, why don't you directly base this onto your branch which makes the divemode time depenent (which is in my opinion close to merging)?"}],"action":{"name":"View Pull Request","url":"https://github.com/Subsurface-divelog/subsurface/pull/1166#issuecomment-382390636"}}}</script>
</blockquote>
<p>Hi Robert,</p>
<p>Your first question. When diving SCR rebreather, an important
factor is the oxygen drop over the mouthpiece, i.e. the
difference between OC-pO2 and actually-measured pO2 in the loop
of the rebreather; i.e. the vertical difference between the red
and the green graphs in my initial screenshot. The larger the
pO2 drop, the more decompression is added to the end of the dive
because less oxygen usually means more nitrogen. However, the
smaller the pO2 drop, the less efficient the rebreather is
working and the SAC rate increases. On active SCR this is
controlled by setting the rate of continuous gas addition. On
pSCR this is controlled by opening or closing the gas release
valve on the counterlung. So the vertical distance between the
two graphs should ideally not be too large or too small, or at
least managed within the objectives of the dive. In the case of
a sticky or free-flowing injector, the red and green graphs
start to converge, i.e. the closer one moves to an OC situation
with little re-circulation of gas. Therefore sufficient distance
between the red and green graphs is also an indication of
well-working equipment. As indicated before, it is a situation
very analogous to the setpoint of CCR equipment which provides a
reference of how efficiently the gas addition management system
works.</p>
<p>Your second question. This code is entirely independent of the
divemode-dependent code, since pSCR dive logs is already part of
the software. As you know, the divemode-dependent branch
primarily deals with bailout, which is an entirely different
issue. Anyway, that is how I rationalised this to myself a month
ago.</p>
<p>I hope I make some sense.</p>
<p>Kind regards,</p>
<p>willem</p>
<p><br>
</p>
<p><br>
</p>
</div>
</body>
</html>
<br>
<div style="font-family:Arial,Helvetica,sans-serif"><span style="font-size:10.0pt;line-height:105%;font-family:"Segoe UI",sans-serif">This message and attachments are subject to a disclaimer.<br>
Please refer to <a href="http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf" target="_blank">http://upnet.up.ac.za/<wbr>services/it/documentation/<wbr>docs/004167.pdf</a> </span><span style="font-size:10pt;line-height:105%;font-family:Tahoma,sans-serif">for
full details.</span></div>