<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 22, 2018, at 1:09 PM, Linus Torvalds <<a href="mailto:torvalds@linux-foundation.org" class="">torvalds@linux-foundation.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="auto" class=""><div class=""><br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Sun, Apr 22, 2018, 12:42 Dirk Hohndel <<a href="mailto:dirk@hohndel.org" class="">dirk@hohndel.org</a>> wrote:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="">
I know we initially didn't use the fingerprint (5 or so years ago) because back then something was broken with it.<br class="">
Linus, is there still a design reason why we can't use it?</blockquote></div></div><div dir="auto" class=""><br class=""></div><div dir="auto" class="">It still has the exact same problem it always had: it's random binary data that we'd have to encode some way. </div><div dir="auto" class=""><br class=""></div><div dir="auto" class="">In practice, I suspect it's always just a number, but the interface is nasty.</div><div dir="auto" class=""><br class=""></div><div dir="auto" class="">It would be much better as a string. Of course. Now it can be anything, so even if it's a string we'd have to encode it somehow.</div><div dir="auto" class=""><br class=""></div><div dir="auto" class="">And for most dive computers it's pure garbage, and it's impossible to tell which dive computer it actually matters for. So you have to encode this garbage whether it's useful or not.</div></div></div></blockquote><br class=""></div><div>You make it sound so wonderful... libdivecomputer returns a char * and a size to us - which is different for different dive computers. Lovely.</div><div>So all we can do is store the size and base64 encode the binary data that we get.</div><div><br class=""></div><div>Yeah, it's ugly, but it should make a huge difference in BLE download speed if I understand correctly what's going on.</div><div><br class=""></div><div>/D</div><br class=""></body></html>