<html><head></head><body>It seems more complicated.<br>If I download a new dive from one of my dive computers (Garmin Descent) it creates a new trip for it.<br>If I then download the same dive from a second dive computer (Shearwater Teric) it doesn't merge it with the existing dive, but instead adds it to the correct trip as a separate dive.<br><br>Odd<br><br>/D<br><br><div class="gmail_quote">On June 28, 2019 1:00:44 PM GMT+09:00, Dirk Hohndel <dirk@hohndel.org> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Every time I download a new dive from my dive computer, Subsurface creates a new trip for the downloaded dive instead of adding the dive to the existing dive trip.<br><br>Reading the code I can see that we have two very different paths for "addDive":<br><br>DiveListBase::addDive() which is called when importing from a dive computer - which doesn't even try to match the dive to an existing trip<br>AddDive::addDive() which appears to do the right thing, but creates an undo event per dive that's added (which isn't what we want for the import).<br><br>Berthold, I tried to figure out how to make DiveListBase::addDive() do the right thing, but I think it would be easier if you took a look. My attempts didn't look right :-)<br>(and didn't work).<br><br>Thanks<br><br>/D<hr>subsurface mailing list<br>subsurface@subsurface-divelog.org<br><a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface">http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface</a><br></pre></blockquote></div><br>-- <br>From my phone</body></html>