<html><head></head><body>I'll make a new Subsurface-mobile beta available over the weekend which should fix this issue.<br><br>/D<br><br><div class="gmail_quote">On July 5, 2019 7:55:32 AM PDT, Monty Taylor <mordred@inaugust.com> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail"><br><br>On 6/28/19 3:48 AM, Dirk Hohndel wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">No, this is all on the Mac.<br></blockquote><br>I'm seeing this on Mobile.<br><br>I'm running on the beta channel - 2.1.6(4.8.4.577) on Android and <br>downloading from Shearwater Perdix over Bluetooth LE.<br><br>I see the same issue Dirk reported - that each new download imports the <br>dives into a new trip, rather than adding them to the existing trip. It <br>does this whether it's an additional dive on the same day, or the next <br>day - really no matter what.<br><br>However, this is not happening for my wife, who is running <br>2.1.6(4.8.4.66) using mobile on Android and downloading from Shearwater <br>Perdix over Bluetooth LE. For her, new dives are correctly being added <br>to the existing trip.<br><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">On June 28, 2019 1:56:08 PM GMT+09:00, Berthold Stoeger <br><bstoeger@mail.tuwien.ac.at> wrote:<br><br> Hi Dirk,<br><br> On Friday, 28 June 2019 06:00:44 CEST Dirk Hohndel wrote:<br><br> Every time I download a new dive from my dive computer,<br> Subsurface creates a<br> new trip for the downloaded dive instead of adding the dive to<br> the existing<br> dive trip.<br><br><br> Miika reported the same problem.<br><br> Reading the code I can see that we have two very different paths for<br> "addDive":<br><br> DiveListBase::addDive() which is called when importing from a<br> dive computer<br> - which doesn't even try to match the dive to an existing trip<br> AddDive::addDive() which appears to do the right thing, but<br> creates an undo<br> event per dive that's added (which isn't what we want for the<br> import).<br><br><br> Dive import on desktop works via Command::importDives(). Whether a new trip is<br> generated is controlled with the IMPORT_ADD_TO_NEW_TRIP flag. See desktop-<br> widgets/downloadfromdivecomputer.cpp.<br><br> I reckon that you download with your phone? I can try to switch that to<br> Command::importDives() but I think I would have to do this "blind", i.e.<br> without the possibility to test. If I remember correctly, BT does not work on<br> my mobile-on-desktop version.<br><br> Berthold<br><br><br><br>-- <br> From my phone<hr>subsurface mailing list<br>subsurface@subsurface-divelog.org<br><a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface">http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface</a><br><br></blockquote><hr>subsurface mailing list<br>subsurface@subsurface-divelog.org<br><a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface">http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface</a><br></pre></blockquote></div><br>-- <br>From my phone</body></html>