<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jan 8, 2020, at 6:13 PM, Gaetan Bisson <<a href="mailto:bisson@archlinux.org" class="">bisson@archlinux.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">[2020-01-08 15:55:34 -1000] Gaetan Bisson:<br class=""><blockquote type="cite" class="">I just rebuilt subsurface from current git master and am getting a<br class="">segfault when downloading dives from my OSTC3. The problem appears to be<br class="">in OstcFirmwareCheck::checkLatest. I'm attaching the full backtrace of<br class="">the crash. I'll investigate more later unless someone beats me to it.<br class=""></blockquote><br class="">So the problem seems to be that I've got an OSTC3 yet the following<br class="">assertion holds:<br class=""><br class=""><span class="Apple-tab-span" style="white-space:pre"> </span>strcmp(data->product, "OSTC 4") == 0)<br class=""><br class="">Since apparently it's libdivecomputer that populates the device_data<br class="">struct, I'd like to report this to them but I don't see any recent<br class="">change that might have broken this, and this issue certainly did not<br class="">exist in mid-december. I'll dig more but for now I'm a bit confused.<br class=""><br class=""></div></div></blockquote><br class=""></div><div>So in <span style="color: rgb(159, 160, 28); font-family: Menlo; font-size: 11px;" class="">commit c36513a9f3e77 </span>we changed how we recognize and try to identify </div><div>OSTC dive computers via BLE (as that is not always reliably possible), but that</div><div>shouldn't have the result that you describe above.</div><div><br class=""></div><div>Typically Anton is a great resource for all things OSTC and especially the parts</div><div>of our code that configure the OSTC. Maybe he has any ideas?</div><div><br class=""></div><div>/D</div></body></html>