<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Linus,<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 14. Feb 2020, at 21:19, Linus Torvalds <<a href="mailto:torvalds@linux-foundation.org" class="">torvalds@linux-foundation.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">NOTE NOTE NOTE! I really hope Robert can test this. None of my dives</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">have dive mode change events. So my testing was pretty darn limited.</span><br style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""></div></blockquote></div><br class=""><div class="">my only test case is a dive I created with the planner with a bailout ascent. But I can confirm that your PR loads this dive correctly.</div><div class=""><br class=""></div><div class="">But once more, I have to admit, a quick read through did not really reveal to me how it works when handling multiple strings.</div><div class=""><br class=""></div><div class="">But I thought that given there is no clash between dive mode names and strings that can appear as event names, simply make name=„OC“ and similar a feature. Please have a look at </div><div class=""><br class=""></div><div class=""><a href="https://github.com/Subsurface-divelog/subsurface/pull/2622" class="">https://github.com/Subsurface-divelog/subsurface/pull/2622</a></div><div class=""><br class=""></div><div class="">which also fixes the problem.</div><div class=""><br class=""></div><div class="">What do you think?</div><div class=""><br class=""></div><div class="">Best</div><div class="">Robert</div></body></html>