<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body>
<p>Hi Dirk,</p>
<p>I did the integration of the Icon HD VID/PID pair, so if the
testing is successful I think there is nothing left for me to do
before a merge.</p>
<p>Someone just tested with an Mares Nemo Wide (Serial < 50000),
and it did also work.<br>
</p>
<p>Just for clarification about the possible UI changes (now that
I'm more awake again), I would envision a workflow like this:<br>
- When opening the divecomputer-screen, or pressing the refresh
button ("Neu Scannen" in german), get all UsbDevices by issuing
UsbManager.getDeviceList(). Use these to populate the connection
("Verbindung") list. (Only show the entries with specified
driver-class when this is activated in the settings). I think
there has to be done some work in the bt-discovery part so that
these two mechanisms can work together.<br>
- When a device from the connection list is selected, maybe try to
guess Vendor / Model by data provided in the UsbDevice-Object.
There is already some code in QMLManager::showDownloadPage. I'm
not sure how much there can be done since it seems that a lot of
devices use the same PID/VIDs.<br>
- When the download-button is pressed, the UsbDevice-Object of the
selected connection (and if selected the name of the driver-class)
should be passed to serial_android_usb_open. From there on I can
do the work.</p>
<p>There would probably also have to be done some changes when
receiving the USB_DEVICE_ATTACHED intent so that the correct entry
of the list is preselected.<br>
</p>
<p>Best regards<br>
Christof<br>
</p>
<div class="moz-cite-prefix">On 07.03.20 02:11, Dirk Hohndel via
subsurface wrote:<br>
</div>
<blockquote type="cite"
cite="mid:FADB10CF-F010-416E-B9F6-28D8A8A9F2A1@hohndel.org">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On Mar 6, 2020, at 5:03 PM, Christof Arnosti
<<a href="mailto:charno@charno.ch" class=""
moz-do-not-send="true">charno@charno.ch</a>> wrote:</div>
<div class="">
<div class="">
<blockquote type="cite"
cite="mid:80969050-52D2-4D92-B0B2-C6B7D7001360@hohndel.org"
class="">
<div class="">And here you are losing me again :-)</div>
<div class="">Are you suggesting that we could walk
through the list of devices and try to populate the
dropdowns on the download page accordingly? That
sounds like a great idea.</div>
</blockquote>
Yes, that's exactly what I tried to suggest. Thanks for
putting it in understandable words, it's getting late
here.<br class="">
</div>
</div>
</blockquote>
<div><br class="">
</div>
<div>It is indeed.</div>
<br class="">
<blockquote type="cite" class="">
<div class="">
<div class="">
<blockquote type="cite"
cite="mid:80969050-52D2-4D92-B0B2-C6B7D7001360@hohndel.org"
class="">
<div class="">
<blockquote type="cite" class="">
<div class="">
<div class="">
<p class="">I didn't consciously check for
devices not entered in the device_filter.xml,
but I entered "my" PID/VID pair quite late in
the development cycle. I also have seen and
used the "ask permission" popup which happens
when a device not in device_filter.xml is
used. I will test this tomorrow by removing
"my" entry from the device_filter.xml.<br
class="">
</p>
</div>
</div>
</blockquote>
<br class="">
</div>
<div class="">Excellent. Should I wait for further
updates from you before merging the current code?</div>
</blockquote>
<p class="">Hmm... I'd propose that I add the
CdcAcm-driver for the Icon HD VID/PID (if this works
then all the PID/VIDs from <a
href="http://libdivecomputer.org/drivers.html"
class="" moz-do-not-send="true">libdivecomputer.org/drivers.html</a>
are be supported! :-D) tomorrow, and that you then merge
the code if everything else is fine. <br class="">
</p>
</div>
</div>
</blockquote>
<div><br class="">
</div>
<div>That sounds excellent to me. I can test this and then merge
the PR.</div>
</div>
</blockquote>
<blockquote type="cite"
cite="mid:FADB10CF-F010-416E-B9F6-28D8A8A9F2A1@hohndel.org">
<div><br class="">
<blockquote type="cite" class="">
<div class="">
<div class="">
<p class=""> </p>
<p class="">Work on the UI could be done in a separate
branch, and I'm happy to help on the driver side.<br
class="">
</p>
</div>
</div>
</blockquote>
<br class="">
</div>
<div>That was my plan. I'll do the UI / integration work and we'll
figure out what's needed on the driver side to make this work.</div>
<div><br class="">
</div>
<div>So exciting!</div>
<div><br class="">
</div>
<div>/D</div>
<br class="">
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
subsurface mailing list
<a class="moz-txt-link-abbreviated" href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a>
<a class="moz-txt-link-freetext" href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface">http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface</a>
</pre>
</blockquote>
</body>
</html>