<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">I don't see this math error here which is weird - even with a completely clean build.<div class="">Nor do we see it in the GitHub Action build.</div><div class=""><br class=""></div><div class="">The issue with QtCharts was an oversight on my part. I apparently had this manually fixed at some point and then always benefited from the files being there already (i.e., I never deleted my Subsurface.app bundle between builds).</div><div class="">I just pushed a commit into master that should fix that (tried here with a clean build).</div><div class=""><br class=""></div><div class=""><div class="">commit 48c3e017d6b2c720e656b072d1be554bb73e3d89 (HEAD -> master, origin/master, origin/HEAD)</div><div class="">Author: Dirk Hohndel <<a href="mailto:dirk@hohndel.org" class="">dirk@hohndel.org</a>></div><div class="">Date: Fri Jan 1 09:56:58 2021 -0800</div><div class=""><br class=""></div><div class=""> build-system: fix macOS QtCharts QML resources</div><div class=""> </div><div class=""> On macOS the cmake build system doesn't copy the QML resources into the app</div><div class=""> bundle and so we do that manually. I forgot to add that for QtCharts.</div><div class=""> </div><div class=""> Signed-off-by: Dirk Hohndel <<a href="mailto:dirk@hohndel.org" class="">dirk@hohndel.org</a>></div><div class=""><br class=""></div><div class="">diff --git a/CMakeLists.txt b/CMakeLists.txt</div><div class="">index 470ecae0a..4cb3effe1 100644</div><div class="">--- a/CMakeLists.txt</div><div class="">+++ b/CMakeLists.txt</div><div class="">@@ -497,6 +497,7 @@ elseif(CMAKE_SYSTEM_NAME STREQUAL "Darwin")</div><div class=""> install(CODE "execute_process(COMMAND cp -a ${_qt5Core_install_prefix}/qml/QtQuick.2 ${CMAKE_BINARY_DIR}/${APP_BUNDLE_DIR}/Contents/Resources/qml)")</div><div class=""> install(CODE "execute_process(COMMAND cp -a ${_qt5Core_install_prefix}/qml/QtLocation ${CMAKE_BINARY_DIR}/${APP_BUNDLE_DIR}/Contents/Resources/qml)")</div><div class=""> install(CODE "execute_process(COMMAND cp -a ${_qt5Core_install_prefix}/qml/QtPositioning ${CMAKE_BINARY_DIR}/${APP_BUNDLE_DIR}/Contents/Resources/qml)")</div><div class="">+ install(CODE "execute_process(COMMAND cp -a ${_qt5Core_install_prefix}/qml/QtCharts ${CMAKE_BINARY_DIR}/${APP_BUNDLE_DIR}/Contents/Resources/qml)")</div><div class=""> if(NOT Qt5Core_VERSION VERSION_LESS 5.11.0)</div><div class=""> # and with Qt 5.11 we need another library that isn't copied by macdeployqt</div><div class=""> install(CODE "execute_process(COMMAND rm -rf ${CMAKE_BINARY_DIR}/${APP_BUNDLE_DIR}/Contents/Frameworks/QtPositioningQuick.framework)")</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div><br class=""><blockquote type="cite" class=""><div class="">On Jan 1, 2021, at 9:25 AM, Doug Junkins <<a href="mailto:douglas.junkins@gmail.com" class="">douglas.junkins@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">I ran into the same problems as Robert trying to build the bstoeger-statistics branch on MacOS 10.15.7 with Qt 5.15.2 installed with QtCharts, but haven’t had a chance to dig into the issue yet (other than confirming that adding #include <cmath> fixes the missing std::isnan() reference.)<br class=""><div class=""><br class=""></div><div class="">-Doug</div><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Jan 1, 2021, at 9:12 AM, Dirk Hohndel via subsurface <<a href="mailto:subsurface@subsurface-divelog.org" class="">subsurface@subsurface-divelog.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Oh yes, all my tests of the statistics code have been on macOS 10.15.<br class=""><br class="">What I think you are seeing is that not all required QML modules and plugins were automatically moved into the app folder.<br class="">I have a few family things to take care of this morning, but I'll try a clean build and make sure that everything works as designed <br class=""><br class="">/D<br class=""><br class=""><div class="gmail_quote">On January 1, 2021 8:29:00 AM PST, Berthold Stoeger via subsurface <<a href="mailto:subsurface@subsurface-divelog.org" class="">subsurface@subsurface-divelog.org</a>> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">Hi Robert,<br class=""><br class="">On Freitag, 1. Jänner 2021 16:00:28 CET Robert Helling via subsurface wrote:<br class=""><br class=""><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">First thing I noticed was that the compiler complains about not knowing<br class="">about std::isnan(). But since there is (and is suggested by the compiler)<br class="">isnan(), I changed all occurrences in this way. Maybe I am still using an<br class="">old version of the C++ standard, but this seemed to do the job.<br class=""></blockquote><br class="">Please try<br class=""><br class="">#include <math.h><br class=""><br class="">or<br class=""><br class="">#include <cmath><br class=""><br class="">in the respective files. I'm not sure, but I think that it would be standards-<br class="">conforming if the first version would not populate the std-namespace and the <br class="">second version would not populate the global namespace. However, I doubt that <br class="">compilers are that unhelpful, so either should work.<br class=""><br class=""><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;">th-nb-tmpmbp05-6766:build Helling$ Subsurface.app/Contents/MacOS/Subsurface<br class="">MapWidget.qml: cannot find a plugin named: googlemaps<br class="">1 , "The geoservices provider is not supported."<br class="">qrc:/qml/MapWidget.qml:24: Error: Cannot assign [undefined] to<br class="">QDeclarativeGeoMapType* Populating font family aliases took 923 ms. Replace<br class="">uses of missing font family "'Bookman URW'" with one that exists to avoid<br class="">this cost. qrc:/qml/statsview.qml:3:1: module "QtCharts" is not installed<br class=""> import QtCharts 2.0<br class=""> ^<br class="">QObject::connect(QtCharts::QChart, StatsView): invalid null parameter<br class="">Segmentation fault: 11<br class=""><br class=""><br class="">I know I have QtCharts installed (at first I had not in my Qt 5.12 that I<br class="">had used so far and then already cmake complained). But somehow QML refuses<br class="">to import it. Any ideas how to fix this?<br class=""></blockquote><br class="">Can't help you with that, sorry. But I'm pretty sure that Dirk tested it on <br class="">MacOS.<br class=""><br class="">Berthold<hr class="">subsurface mailing list<br class=""><a href="mailto:subsurface@subsurface-divelog.org" class="">subsurface@subsurface-divelog.org</a><br class=""><a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" class="">http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface</a><br class=""></pre></blockquote></div><br class="">-- <br class="">Sent from my phone</div>_______________________________________________<br class="">subsurface mailing list<br class=""><a href="mailto:subsurface@subsurface-divelog.org" class="">subsurface@subsurface-divelog.org</a><br class=""><a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" class="">http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface</a><br class=""></div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></div></body></html>