<html><head>
<style id="pgp_css" type="text/css"><!----></style><style type="text/css"><!--#x165698ad2f0a477 blockquote.cite2
{margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right: 0px; border-left: 1px solid rgb(204, 204, 204); margin-top: 3px; padding-top: 0px;}
#x165698ad2f0a477
{font-family: "Segoe UI"; font-size: 12pt;}
--></style><style id="css_styles" type="text/css"><!--blockquote.cite { margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right:0px; border-left: 1px solid #cccccc }
blockquote.cite2 {margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right:0px; border-left: 1px solid #cccccc; margin-top: 3px; padding-top: 0px; }
a img { border: 0px; }
li[style='text-align: center;'], li[style='text-align: center; '], li[style='text-align: right;'], li[style='text-align: right; '] { list-style-position: inside;}
body { font-family: Segoe UI; font-size: 12pt; }
.quote { margin-left: 1em; margin-right: 1em; border-left: 5px #ebebeb solid; padding-left: 0.3em; }--></style>
</head>
<body><div>Of course I'd find something that appears simple but is trickier than it might first seem!</div><div><br /></div><div>I've create issue #3256 <a href="https://github.com/subsurface/subsurface/issues/3256" style="font-size: 12pt;">https://github.com/subsurface/subsurface/issues/3256</a></div><div><br /></div><div>Only after sending my email did I actually rebuild after my edits to the en_GB translation file to find that I was naive in thinking it was that simple :) </div><div><br /></div><div>The specific case I'm referring to is using en_GB, and for the dive trip summary line in the dive list.</div>
<div><br /></div>
<div>------ Original Message ------</div>
<div>From: <a href="mailto:dirk@hohndel.org">dirk@hohndel.org</a></div>
<div>To: "Mark Stiebel" <<a href="mailto:mark@stiebel.me">mark@stiebel.me</a>>; "Mark Stiebel via subsurface" <<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a>>; <a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a></div>
<div>Sent: 27/05/2021 12:39:00 PM</div>
<div>Subject: Re: Contributing</div><div><br /></div>
<div id="x165698ad2f0a477"><blockquote cite="1F88E5FA-F0CB-43F5-B6A1-603433F6D849@hohndel.org" type="cite" class="cite2">
This is actually one of the trickier things to work on.<br />The numerous forms are a bit of a pain to get right. Are you talking about en-US out en-GB?<br />And which strings?<br /><br />I think the best way to do this would be to file an issue on GitHub where you show example strings and then I'll try and point you in the right direction...<br /><br />/D<br /><br /><div class="gmail_quote">On May 26, 2021 4:57:46 PM PDT, Mark Stiebel via subsurface <<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a>> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br /><div>I've been looking for a way to ease myself into contributing, and think I found a straightforward candidate... </div><div><br /></div><div>I noticed that in a lot of the text throughout Subsurface it uses the old "dive(s)" rather than choosing the singular or plural form. Then I noticed that this is taken care of, and its just that the en-GB language files do not have the correct values in the <numerusform> tags.</div><div><br /></div><div>So, what's the preferred process for me to correct this? Do I just create a bug ticket on git, create a branch for my fix then a PR?</div><div><br /></div><div>Thx,</div><div>Mark.</div><div><br /></div></blockquote></div><br />-- <br />from my phone</blockquote></div>
</body></html>