[subsurface] Miscellaneous fixes, mostly UI stuff (#107)

[Linus Torvalds]

Ok, guys, *please* don't use github pull requests, they are completely
and utterly broken, and make it pretty much impossible to see from
whom the pull request actually is, since github corrupts all the email
addresses etc.

So feel free to use github as a git *hosting* site - something github
is excellent at. But PLEASE PLEASE PLEASE don't use the totally broken
github pull request logic, do the "git request-pull" thing instead and
send it as real email to the real subsurface mailing list and to me!

Anyway, since I was merging stuff, I did end up merging this too.
However, it clashed pretty badly with the save-on-exit changes by
Pierre-Yves Chibon, and while I think I merged it reasonably, I'd like
the people involved to please take another look at the resulting code.
Just to see if I missed something - it's entirely possible that I did,
since both Pierre-Yves and Mikko did that same "Save As" logic, but
slightly differently and for somewhat different reasons.

                Linus

On Tue, Jul 31, 2012 at 11:30 AM, DataBeaver
<reply+i-5950368-074c92df82eb449f52feea0f8c2a000e63e0df32-1024025 at reply.github.com>
wrote:
> The commit messages should speak for themselves.
>
> I tried my best to make good commits.  However, since they're mostly unrelated, I wasn't sure of whether to create separate pull requests or just one (or for that matter, whether to even create a branch for these).  In the end I decided that there'd be too much overhead in having multiple requests with just one commit in each.  Let me know if you'd rather have separate requests (with the two menu-related commits possibly bunched together).
>
> ps. Great that there's finally a divelog written in C that's (hopefully) being actively maintained!  I don't much care for Java, and gdivelog has been unmaintained for several years.
>
> You can merge this Pull Request by running:
>
>   git pull https://github.com/DataBeaver/subsurface misc-fixes
>
> Or you can view, comment on it, or merge it online at:
>
>   https://github.com/torvalds/subsurface/pull/107
>
> -- Commit Summary --
>
> * Divide the panes evenly in view_three
> * Improved depth info for dives without samples
> * Changes to menu icons
> * Add a separate "Save as" entry to the menu
>
> -- File Changes --
>
> M dive.c (5)
> M divelist.c (6)
> M gtk-gui.c (41)
> M info.c (16)
> M profile.c (7)
>
> -- Patch Links --
>
>   https://github.com/torvalds/subsurface/pull/107.patch
>   https://github.com/torvalds/subsurface/pull/107.diff
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/torvalds/subsurface/pull/107