[subsurface] Miscellaneous fixes, mostly UI stuff (#107)

Mikko Rasa tdb at tdb.fi
Fri Aug 17 13:06:00 PDT 2012


On 17.08.2012 21:05, Linus Torvalds wrote:
> Ok, guys, *please* don't use github pull requests, they are completely
> and utterly broken, and make it pretty much impossible to see from
> whom the pull request actually is, since github corrupts all the email
> addresses etc.
>
> So feel free to use github as a git *hosting* site - something github
> is excellent at. But PLEASE PLEASE PLEASE don't use the totally broken
> github pull request logic, do the "git request-pull" thing instead and
> send it as real email to the real subsurface mailing list and to me!

Duly noted.  I'll do that next time.

> Anyway, since I was merging stuff, I did end up merging this too.
> However, it clashed pretty badly with the save-on-exit changes by
> Pierre-Yves Chibon, and while I think I merged it reasonably, I'd like
> the people involved to please take another look at the resulting code.
> Just to see if I missed something - it's entirely possible that I did,
> since both Pierre-Yves and Mikko did that same "Save As" logic, but
> slightly differently and for somewhat different reasons.

The merge looks reasonable to me.  I'm going diving this weekend so I'll 
give it a spin next week and verify that everything is ok.

-- 
Mikko


More information about the subsurface mailing list