[PATCH 1/2] Added a function to check if specific OS features are available
dirk at hohndel.org
Mon Oct 22 10:52:17 PDT 2012
Henrik Brautaset Aronsen <subsurface at henrik.synth.no> writes:
> Den 22.10.12 18:53, skrev Dirk Hohndel:
>> Yes, we manually turn them off if we detect that you are running XP.
>> Fundamentally it appears to be rather unreliable to figure out if a font
>> on Windows does have the glyphs that we are looking for. We identified
>> several versions of XP (localized and non-localized, SP1 and SP3) that
>> don't appear to have the star glyphs. So those people would get odd
>> characters instead of the stars. It seemed better to simply give
>> everyone on XP (I assume - VERY FEW actual users) the lame "*" version
>> than to have it fail badly for some...
> No, there's definitely something wrong. Look at the images this time,
> all from rc3 on WinXP SP3:
> * test-1:
> I've selected a dive without a rating. The rating box is completely
> blank, i.e. " " is used as blank stars.
> The rating menu, however, shows
> unicode stars.
Yikes. That is definitely NOT what we wanted. I'll need to look at the
code tonight (unless Lubomir beats me to it)
> * test-2:
> I've chosen three stars as rating. The rating box shows unicode stars
> this time.
> * test-3:
> I've pressed OK to store the dive. The rating is not saved. Also see
> that the dive menu header shows a "*", i.e. a non-unicode star.
> Something's messed up, it seems.
The "not saved" thing is weird - I thought we had all the non-saving
bugs figured out. That's the part that scares me the most.
The inconsistent use of font is likely an oversight of one code path in
Lubomir's change... it's of course not what we want to have but
(hopefully) easy to fix.
More information about the subsurface